Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Disable threading test that fails on CI #47034

Merged
jonahwilliams merged 1 commit into from
Oct 18, 2023
Merged

Disable threading test that fails on CI #47034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions impeller/renderer/backend/vulkan/test/gpu_tracer_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,34 +77,6 @@ TEST(GPUTracerVK, DoesNotTraceOutsideOfFrameWorkload) {
"vkGetQueryPoolResults") == called->end());
}

TEST(GPUTracerVK, DoesNotTraceOtherTheads) {
auto const context = MockVulkanContextBuilder().Build();

auto tracer = std::make_shared<GPUTracerVK>(context->GetDeviceHolder());

ASSERT_TRUE(tracer->IsEnabled());

tracer->MarkFrameStart();

// Record the cmd buffer on another thread to simulate a mipmap cmd buffer.
std::thread image_upload_thread([&context]() {
auto cmd_buffer = context->CreateCommandBuffer();
auto vk_cmd_buffer = CommandBufferVK::Cast(cmd_buffer.get());
auto blit_pass = cmd_buffer->CreateBlitPass();
if (!cmd_buffer->SubmitCommands()) {
VALIDATION_LOG << "Failed to submit commands";
}
});

image_upload_thread.join();

auto called = GetMockVulkanFunctions(context->GetDevice());

ASSERT_NE(called, nullptr);
ASSERT_TRUE(std::find(called->begin(), called->end(), "vkCreateQueryPool") ==
called->end());
}

#endif // IMPELLER_DEBUG

} // namespace testing
Expand Down