Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Avoid invalid GL depth calls on macOS desktop. #46758

Merged
bdero merged 1 commit into from
Oct 11, 2023
Merged

[Impeller] Avoid invalid GL depth calls on macOS desktop. #46758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions impeller/renderer/backend/gles/render_pass_gles.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,12 @@ struct RenderPassData {
pass_data.clear_color.alpha // alpha
);
if (pass_data.depth_attachment) {
// TODO(bdero): Desktop GL for Apple requires glClearDepth. glClearDepthf
// throws GL_INVALID_OPERATION.
// https://github.com/flutter/flutter/issues/136322
#if !FML_OS_MACOSX
gl.ClearDepthf(pass_data.clear_depth);
#endif
}
if (pass_data.stencil_attachment) {
gl.ClearStencil(pass_data.clear_stencil);
Expand Down Expand Up @@ -303,7 +308,12 @@ struct RenderPassData {
viewport.rect.size.height // height
);
if (pass_data.depth_attachment) {
// TODO(bdero): Desktop GL for Apple requires glDepthRange. glDepthRangef
// throws GL_INVALID_OPERATION.
// https://github.com/flutter/flutter/issues/136322
#if !FML_OS_MACOSX
gl.DepthRangef(viewport.depth_range.z_near, viewport.depth_range.z_far);
#endif
}

//--------------------------------------------------------------------------
Expand Down