This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Make CreateMockVulkanContext() thread-safe
#45687
Merged
+78
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Sep 12, 2023
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
Thanks, looks good to me. I just have a few minor comments.
Thanks! Co-authored-by: gaaclarke <[email protected]>
Done, thanks for the suggested change. Co-authored-by: gaaclarke <[email protected]>
matanlurey
added
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/45687, due to - The status or check suite Linux Framework Smoke Tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/45687, due to - The status or check suite Linux Framework Smoke Tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 12, 2023
…134569) flutter/engine@d4698c6...496ef6a 2023-09-12 [email protected] Roll Skia from 7cafb622ee7f to a4f8f5177c8b (1 revision) (flutter/engine#45719) 2023-09-12 [email protected] Roll Fuchsia Linux SDK from vGleXqh2SRUNJM7JN... to MWWrSP9mSVlGIOaDo... (flutter/engine#45718) 2023-09-12 [email protected] Roll Skia from 438ec87ea2be to 7cafb622ee7f (1 revision) (flutter/engine#45716) 2023-09-12 [email protected] [Impeller] Make `CreateMockVulkanContext()` thread-safe (flutter/engine#45687) 2023-09-12 [email protected] [Impeller] moved validation layers on by default logic to gni scripts (flutter/engine#45682) 2023-09-12 [email protected] Roll Skia from f3f0cab7efd0 to 438ec87ea2be (1 revision) (flutter/engine#45714) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from vGleXqh2SRUN to MWWrSP9mSVlG If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started using
CreateMockVulkanContext()in #45654, and discovered that it was not thread-safe. This PR does a little bit of refactoring/TLC to ensure that functions and buffers can be accessed across threads (like the realContextVK).The attached test (test for a test fixture, hoorah!) fails consistently before the changes, and passes after. Note that if you try testing this with
--gtest_repeat=10000(at least that's the threshold for me), it'll fail - that's actually due to flutter/flutter#134482 which in turn is being fixed in #45686.(Unblocks flutter/flutter#133198)