Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Aug 7, 2023

@mdebbar mdebbar requested a review from eyebrowsoffire August 7, 2023 21:05
@github-actions github-actions bot added the platform-web Code specifically for the web engine label Aug 7, 2023
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2023
@auto-submit auto-submit bot merged commit 73671d4 into flutter:main Aug 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 8, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 8, 2023
…132141)

flutter/engine@99fdac8...22bd35a

2023-08-08 [email protected] [macOS] Fix engine/binaryMessenger retain cycle (flutter/engine#44471)
2023-08-08 [email protected] Roll Skia from f7162d33afb2 to 66ba512c613c (8 revisions) (flutter/engine#44497)
2023-08-08 [email protected] [web] Expose the benchmark callback through dart:ui_web (flutter/engine#44461)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 8, 2023
@reidbaker reidbaker mentioned this pull request Aug 15, 2023
14 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants