Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] trimmed 3 bytes off of each Glyph #44054

Merged
auto-submit merged 2 commits into from
Jul 27, 2023
Merged

[Impeller] trimmed 3 bytes off of each Glyph #44054

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ed36de
[Impeller] trimmed 3 bytes off of each Glyph
gaaclarke Jul 26, 2023
74e97bb
added comment
gaaclarke Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion impeller/typographer/glyph.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace impeller {
/// @brief The glyph index in the typeface.
///
struct Glyph {
enum class Type {
enum class Type : uint8_t {
kPath,
kBitmap,
};
Expand All @@ -39,6 +39,10 @@ struct Glyph {
: index(p_index), type(p_type), bounds(p_bounds) {}
};

// Many Glyph instances are instantiated, so care should be taken when
// increasing the size.
static_assert(sizeof(Glyph) == 20);
Copy link
Contributor

@dnfield dnfield Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment about this?

Copy link
Member Author

@gaaclarke gaaclarke Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


} // namespace impeller

template <>
Expand Down