This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Enabling the host application to control the timing of attaching the |FlutterView| to the engine #43595
+75
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xZOne
force-pushed
the
task/attach_manually
branch
from
00113e0 to
5d6df6d
Compare
0xZOne
force-pushed
the
task/attach_manually
branch
4 times, most recently
from
4715230 to
cd00b2c
Compare
0xZOne
force-pushed
the
task/attach_manually
branch
from
cd00b2c to
4e6d85f
Compare
Member
|
cc @reidbaker to find a reviewer. |
2 tasks
Member
Author
|
@johnmccutchan Please take a look at it when you have a chance. Many thanks. |
Member
|
Triage: The comments on the linked issue seem to indicate that underlying issue had a workaround. Is this PR stale? |
Member
Author
No, it's not stale. I'm still waiting on a code review. |
| * <p>Defaults to {@code false}. | ||
| */ | ||
| @Override | ||
| public boolean shouldAttachToEngineManually() { |
Contributor
There was a problem hiding this comment.
Can we flip this to be:
attachToEngineAutomatically() {
return true;
}
?
0xZOne
force-pushed
the
task/attach_manually
branch
from
b160ec8 to
5c9eb7d
Compare
…|FlutterView| to the engine.
0xZOne
force-pushed
the
task/attach_manually
branch
from
4a50c88 to
a0e86de
Compare
johnmccutchan
approved these changes
Aug 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2023
…ing the |FlutterView| to the engine (flutter/engine#43595)
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 16, 2023
…132618) flutter/engine@659cdfc...decaccf 2023-08-16 [email protected] Roll Fuchsia Mac SDK from 7iuIq3PsSkuCmuEMr... to Zp9or9YwxZHHPeQbA... (flutter/engine#44747) 2023-08-16 [email protected] Move cache builders to prod. (flutter/engine#44739) 2023-08-16 [email protected] Enabling the host application to control the timing of attaching the |FlutterView| to the engine (flutter/engine#43595) 2023-08-16 [email protected] Roll Skia from 9fc1c628456a to 3d2b84e28e79 (1 revision) (flutter/engine#44746) 2023-08-16 [email protected] Roll Dart SDK from b36934aae968 to e6bf503b36fe (1 revision) (flutter/engine#44745) 2023-08-16 [email protected] [Skia] Only respect ui.Paint.dither when the colorSource is a gradient (flutter/engine#44730) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from 7iuIq3PsSkuC to Zp9or9YwxZHH If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…|FlutterView| to the engine (flutter#43595) In the add-to-app scenario where multiple FlutterViews share the same FlutterEngine, the host application desires to determine the timing of attaching the FlutterView to the engine, for example, during the `onResume` instead of the `onCreateView`. As an example, consider the following scenario: A native page contains multiple tabs, and each tab is a FlutterFragment. During initialization, FlutterFragments of different tabs are created almost simultaneously, but only the one that needs to be displayed currently requires attachment to the engine, while the others need to be attached only when they receive the |onResume| callback. Partial fix: flutter/flutter#130235 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the add-to-app scenario where multiple FlutterViews share the same FlutterEngine, the host application desires to determine the timing of attaching the FlutterView to the engine, for example, during the
onResumeinstead of theonCreateView.As an example, consider the following scenario: A native page contains multiple tabs, and each tab is a FlutterFragment. During initialization, FlutterFragments of different tabs are created almost simultaneously, but only the one that needs to be displayed currently requires attachment to the engine, while the others need to be attached only when they receive the |onResume| callback.
Partial fix: flutter/flutter#130235
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.