This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[iOS][Keyboard] Reland wait vsync on UI thread and update viewport inset to avoid jitter #43463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ewport inset to avoid jitter." (flutter#43422)" This reverts commit 3ade212.
Contributor
|
This PR relands: #42312 |
cyanglaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 10, 2023
…iewport inset to avoid jitter (flutter/engine#43463)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 10, 2023
…130275) flutter/engine@7b826a7...1de141c 2023-07-10 [email protected] Roll Skia from 1c9e2588b577 to 320f01ac1de7 (6 revisions) (flutter/engine#43514) 2023-07-10 [email protected] [iOS][Keyboard] Reland wait vsync on UI thread and update viewport inset to avoid jitter (flutter/engine#43463) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
cyanglaz
pushed a commit
to cyanglaz/engine
that referenced
this pull request
Jul 10, 2023
…set to avoid jitter (flutter#43463) *List which issues are fixed by this PR. You must list at least one issue.* - flutter/flutter#120555 - flutter/flutter#130028 `testKeyboardAnimationWillNotCrashWhenEngineDestroyed` Use `dispatch_async(dispatch_get_main_queue()` to switch to platform thread.
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
…set to avoid jitter (flutter#43463) *List which issues are fixed by this PR. You must list at least one issue.* - flutter/flutter#120555 - flutter/flutter#130028 ### New test for crash case: `testKeyboardAnimationWillNotCrashWhenEngineDestroyed` ### The diff with original PR: Use `dispatch_async(dispatch_get_main_queue()` to switch to platform thread.
gbtb16
pushed a commit
to gbtb16/flutter
that referenced
this pull request
Nov 6, 2023
…lutter#130275) flutter/engine@7b826a7...1de141c 2023-07-10 [email protected] Roll Skia from 1c9e2588b577 to 320f01ac1de7 (6 revisions) (flutter/engine#43514) 2023-07-10 [email protected] [iOS][Keyboard] Reland wait vsync on UI thread and update viewport inset to avoid jitter (flutter/engine#43463) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
I upgraded just yesterday after a few months, so I cant say when regression occurred. It was pretty smooth before. |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List which issues are fixed by this PR. You must list at least one issue.
New test for crash case:
testKeyboardAnimationWillNotCrashWhenEngineDestroyedThe diff with original PR:
Use
dispatch_async(dispatch_get_main_queue()to switch to platform thread.Pre-launch Checklist
///).