Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Document impeller::Context. #43389

Merged
auto-submit merged 2 commits into from
Jul 4, 2023
Merged

[Impeller] Document impeller::Context. #43389

auto-submit merged 2 commits into from
Jul 4, 2023

Conversation

@chinmaygarde
Copy link
Member

@chinmaygarde chinmaygarde commented Jul 3, 2023

No description provided.

@chinmaygarde chinmaygarde self-assigned this Jul 3, 2023
jonahwilliams
jonahwilliams reviewed Jul 3, 2023
View reviewed changes
impeller/renderer/context.h Outdated
class Allocator;

//------------------------------------------------------------------------------
/// @brief Do do anything rendering related with Impeller, you need a
Copy link
Contributor

@jonahwilliams jonahwilliams Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: dodo

Copy link
Member Author

@chinmaygarde chinmaygarde Jul 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

jonahwilliams
jonahwilliams reviewed Jul 3, 2023
View reviewed changes
impeller/renderer/context.h
/// same accelerator using different client APIs (Metal, Vulkan,
/// OpenGL ES, etc..).
///
/// Contexts are thread-safe. They may be created, used, and
Copy link
Contributor

@jonahwilliams jonahwilliams Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small caveat here in that they may still need to be destructed on the thread they were created from, at least as long as they own their own concurrent worker loop.

Copy link
Contributor

@jonahwilliams jonahwilliams Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, I guess not on the thread it was constructed on - just not on a worker thread from an internal pool

Copy link
Member Author

@chinmaygarde chinmaygarde Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the clarification.

jonahwilliams
jonahwilliams approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 3, 2023
@auto-submit auto-submit bot merged commit 92f1f3d into flutter:main Jul 4, 2023
@chinmaygarde chinmaygarde deleted the docpeller branch July 4, 2023 01:36
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
270794c 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
537a533 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
dd96190 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
0f2b259 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
d533f87 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
1715118 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
e696095 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
d23c986 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
31d4a01 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
53aa248 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
e727110 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
03d8764 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
97d7d97 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
2c2af27 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 5, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
0eb0245 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 5, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
985e945 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 5, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
02fde1b 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 5, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
be58b96 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 5, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
535ba8a 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 5, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
253d852 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 5, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
8af4a40 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 5, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
37f039f 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 5, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 5, 2023
@engine-flutter-autoroll
92f1f3d96 [Impeller] Document impeller::Context. (flutter/engine#43389
3ba105d 
)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 5, 2023
@engine-flutter-autoroll
Manual roll Flutter Engine from 987b621eac4e to bd2e42b203e1 (32 revi…
5535937 
…sions) (#130023)

Manual roll Flutter Engine from 987b621eac4e to bd2e42b203e1 (32 revisions)

Manual roll requested by [email protected]

flutter/engine@987b621...bd2e42b

2023-07-05 [email protected] Reverts Dart SDK to version 3.1.0-262.0.dev (flutter/engine#43417)
2023-07-05 [email protected] Roll Fuchsia Mac SDK from 8YulTHvG-Jg3Sof-S... to C3Q7MJBYkiin8zw-f... (flutter/engine#43415)
2023-07-05 [email protected] Roll Dart SDK from f7c242ded366 to e193587883d6 (1 revision) (flutter/engine#43414)
2023-07-05 [email protected] Roll Skia from a453fed07c91 to d58324bf653d (1 revision) (flutter/engine#43413)
2023-07-05 [email protected] Roll Skia from faf906db84ab to a453fed07c91 (4 revisions) (flutter/engine#43412)
2023-07-05 [email protected] Roll Dart SDK from c89f5ac4fd46 to f7c242ded366 (1 revision) (flutter/engine#43410)
2023-07-04 [email protected] Roll Fuchsia Mac SDK from 8-taK-r4HkgVAIGtU... to 8YulTHvG-Jg3Sof-S... (flutter/engine#43409)
2023-07-04 [email protected] Roll Dart SDK from 7cd6ed860b63 to c89f5ac4fd46 (1 revision) (flutter/engine#43408)
2023-07-04 [email protected] Roll Dart SDK from d128bd4977a7 to 7cd6ed860b63 (1 revision) (flutter/engine#43406)
2023-07-04 [email protected] Roll Skia from eaca275ef1c0 to faf906db84ab (1 revision) (flutter/engine#43405)
2023-07-04 [email protected] Roll Dart SDK from e58e3bd3b507 to d128bd4977a7 (1 revision) (flutter/engine#43403)
2023-07-04 [email protected] Roll Fuchsia Mac SDK from GNWxBcnfjZlyaOw34... to 8-taK-r4HkgVAIGtU... (flutter/engine#43402)
2023-07-04 [email protected] Roll Skia from bb18c9b1f730 to eaca275ef1c0 (1 revision) (flutter/engine#43401)
2023-07-04 [email protected] Roll Dart SDK from 604ccea2f5b9 to e58e3bd3b507 (1 revision) (flutter/engine#43400)
2023-07-04 [email protected] Roll Skia from 85a3fda32850 to bb18c9b1f730 (3 revisions) (flutter/engine#43399)
2023-07-04 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.1.0 to 4.2.0 (flutter/engine#43398)
2023-07-04 [email protected] Roll Skia from 4abc43e2ffcc to 85a3fda32850 (1 revision) (flutter/engine#43393)
2023-07-04 [email protected] [Impeller] Document `impeller::Context`. (flutter/engine#43389)
2023-07-03 [email protected] Roll Dart SDK from a4c5ed075a2b to 604ccea2f5b9 (1 revision) (flutter/engine#43390)
2023-07-03 [email protected] Roll Dart SDK from c092e09b7e64 to a4c5ed075a2b (1 revision) (flutter/engine#43387)
2023-07-03 [email protected] Roll Skia from 6a5ea15c942b to 4abc43e2ffcc (1 revision) (flutter/engine#43386)
2023-07-03 [email protected] Roll Fuchsia Mac SDK from cytps4RRhs8-wbcVJ... to GNWxBcnfjZlyaOw34... (flutter/engine#43373)
2023-07-03 [email protected] Roll Dart SDK from dedff8f0ebd2 to c092e09b7e64 (1 revision) (flutter/engine#43374)
2023-07-03 [email protected] Roll Skia from 94ad507b8959 to 6a5ea15c942b (1 revision) (flutter/engine#43385)
2023-07-03 [email protected] Roll Skia from e16d5b988a36 to 94ad507b8959 (2 revisions) (flutter/engine#43383)
2023-07-03 [email protected] Roll Skia from 384b84445a9f to e16d5b988a36 (1 revision) (flutter/engine#43382)
2023-07-02 [email protected] Roll Skia from dbf0829114ee to 384b84445a9f (2 revisions) (flutter/engine#43381)
2023-07-01 [email protected] [Impeller] Remove blend mode restrictions on clear color optimization (flutter/engine#43348)
2023-07-01 [email protected] Roll Dart SDK from f00f7363f4bf to dedff8f0ebd2 (4 revisions) (flutter/engine#43371)
2023-07-01 [email protected] Roll Skia from ceaeef84b8a3 to dbf0829114ee (15 revisions) (flutter/engine#43370)
2023-07-01 [email protected] [Impeller] Add explicit color filter types to Aiks. (flutter/engine#43342)
2023-07-01 [email protected] Roll Dart SDK from 2d98d9e27dae to f00f7363f4bf (1 revision) (flutter/engine#43354)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from cytps4RRhs8- to C3Q7MJBYkiin

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

...
kjlubick pushed a commit to kjlubick/engine that referenced this pull request Jul 14, 2023
@chinmaygarde @kjlubick
[Impeller] Document impeller::Context. (flutter#43389)
96c7599
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bdero bdero Awaiting requested review from bdero

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chinmaygarde chinmaygarde

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chinmaygarde @jonahwilliams