This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Apply the transform of an image filter layer to paint bounds in the CanvasKit backend #43353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
force-pushed
the
bug_128788
branch
from
ddfd9f6 to
c3a8e95
Compare
Closed
2 tasks
Contributor
|
Note that once https://skia-review.googlesource.com/c/skia/+/721299 lands this code should be unnecessary since we can just use Skia to do this calculation |
jason-simmons
force-pushed
the
bug_128788
branch
from
c3a8e95 to
7220afd
Compare
…anvasKit backend Fixes flutter/flutter#128788
jason-simmons
force-pushed
the
bug_128788
branch
from
7220afd to
8ccf169
Compare
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 13, 2023
…in the CanvasKit backend (flutter/engine#43353)
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 13, 2023
flutter/engine@b408036...88b8581 2023-07-13 [email protected] Roll Fuchsia Mac SDK from 3C7P0w8ySmtqpyi3S... to rRUd41Mv9NI0n3Iyc... (flutter/engine#43635) 2023-07-13 [email protected] Roll Dart SDK from ade4dae923f3 to 16ddfe8d08e0 (1 revision) (flutter/engine#43634) 2023-07-13 [email protected] Apply the transform of an image filter layer to paint bounds in the CanvasKit backend (flutter/engine#43353) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from 3C7P0w8ySmtq to rRUd41Mv9NI0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 13, 2023
…0502) flutter/engine@b408036...88b8581 2023-07-13 [email protected] Roll Fuchsia Mac SDK from 3C7P0w8ySmtqpyi3S... to rRUd41Mv9NI0n3Iyc... (flutter/engine#43635) 2023-07-13 [email protected] Roll Dart SDK from ade4dae923f3 to 16ddfe8d08e0 (1 revision) (flutter/engine#43634) 2023-07-13 [email protected] Apply the transform of an image filter layer to paint bounds in the CanvasKit backend (flutter/engine#43353) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from 3C7P0w8ySmtq to rRUd41Mv9NI0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
…anvasKit backend (flutter#43353) Fixes flutter/flutter#128788
harryterkelsen
pushed a commit
to harryterkelsen/engine
that referenced
this pull request
Jul 20, 2023
…anvasKit backend (flutter#43353) Fixes flutter/flutter#128788
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#128788