Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Assign missing user to TODO. #43351

Merged
auto-submit merged 2 commits into from
Jun 30, 2023
Merged

[Impeller] Assign missing user to TODO. #43351

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6d8147
Assign missing user to TODO
bdero Jun 29, 2023
316420a
Merge branch 'main' into bdero/todo
bdero Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions impeller/renderer/backend/metal/vertex_descriptor_mtl.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,8 @@ static MTLVertexFormat ReadStageInputFormat(const ShaderStageIOSlot& input) {
const std::vector<ShaderStageBufferLayout>& layouts) {
auto descriptor = descriptor_ = [MTLVertexDescriptor vertexDescriptor];

// TODO: its odd that we offset buffers from the max index on metal
// but not on GLES or Vulkan. We should probably consistently start
// TODO(jonahwilliams): its odd that we offset buffers from the max index on
// metal but not on GLES or Vulkan. We should probably consistently start
// these at zero?
for (size_t i = 0; i < inputs.size(); i++) {
const auto& input = inputs[i];
Expand Down