This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Add Look Up to iOS selection controls #43308
Merged
auto-submit
merged 18 commits into
flutter:main
from
LouiseHsu:add-lookup-to-selection-controls
Jul 6, 2023
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
7d8f5a6
wip searchweb/lookup
LouiseHsu 74f4af7
wip websearch
LouiseHsu e54a359
add tests
LouiseHsu 16dad01
some clean up
LouiseHsu 157f6e1
formatting
LouiseHsu aebfcb8
revert accidental changes
LouiseHsu 96c1fc0
accidental pbxproj commit
LouiseHsu 72bc2a1
whitespace
LouiseHsu e9f0498
whitespace
LouiseHsu d1d7637
Merge branch 'main' into add-lookup-to-selection-controls
LouiseHsu 738c2bf
fix memory leak
LouiseHsu 0070e62
Merge branch 'add-lookup-to-selection-controls' of github.com:louiseh…
LouiseHsu 526ea9e
address PR feedback, fix tests to verify presented view controller
LouiseHsu 399edfb
formatting
LouiseHsu 03512af
Merge branch 'main' into add-lookup-to-selection-controls
LouiseHsu 5bde017
add debug assert
LouiseHsu 4024b9a
Merge branch 'add-lookup-to-selection-controls' of github.com:louiseh…
LouiseHsu e5b28a2
update test to be more specific
LouiseHsu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.