Explicitly cast enum class to int before passing it with a format string #43146
Conversation
…ing. Next version of the crosstool will start warning about this (see: llvm/llvm-project#38717)
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Duplicate of #43139 |
| source->GetTextureDescriptor().sample_count, | ||
| destination->GetTextureDescriptor().sample_count); | ||
| static_cast<int>(source->GetTextureDescriptor().sample_count), | ||
| static_cast<int>(destination->GetTextureDescriptor().sample_count)); |
There was a problem hiding this comment.
Nit: static_cast<std::underlying_type<SampleCount>>?
There was a problem hiding this comment.
(so if the underlying type changed to something where int was problematic, we'd be getting some kind of issue where %d is the right token to use anymore too)
3 participants
Next version of the crosstool will start warning about this (see: llvm/llvm-project#38717)
For context, see cl/542803761
Reviewers, please leave comment in the internal change, thanks.