Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[impeller] Explicitly cast enum class to int before passing it to a formatted string #43139

Merged
auto-submit merged 1 commit into from
Jun 23, 2023
Merged

[impeller] Explicitly cast enum class to int before passing it to a formatted string #43139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions impeller/renderer/blit_pass.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ bool BlitPass::AddCopy(std::shared_ptr<Texture> source,
VALIDATION_LOG << SPrintF(
"The source sample count (%d) must match the destination sample count "
"(%d) for blits.",
source->GetTextureDescriptor().sample_count,
destination->GetTextureDescriptor().sample_count);
static_cast<int>(source->GetTextureDescriptor().sample_count),
static_cast<int>(destination->GetTextureDescriptor().sample_count));
Copy link
Member

@bdero bdero Jun 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: static_cast<std::underlying_type<SampleCount>>?

Copy link
Member

@bdero bdero Jun 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it makes sense to always interpret as int here. The cast should fail if it were even possible for something exotic to happen with the underlying type (won't happen).

Copy link

@alexfh alexfh Jun 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be int, since %d placeholders require an int argument.

return false;
}

Expand Down