Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] sort all vertex inputs by location. #42664

Merged
auto-submit merged 2 commits into from
Jun 8, 2023
Merged

[Impeller] sort all vertex inputs by location. #42664

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
220aaef
[Impeller] sort all vertex inputs by location.
Jun 8, 2023
1d3850f
Update vertex_descriptor.cc
Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions impeller/renderer/vertex_descriptor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,14 @@ bool VertexDescriptor::SetStageInputs(
for (size_t i = 0; i < count; i++) {
inputs_.emplace_back(*stage_inputs[i]);
}
// TODO(jonahwilliams): vulkan shader stage needed sorting too. Remove once
// autogenerated headers include offset information.
Copy link
Contributor

@dnfield dnfield Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link an issue tracking this work.

Copy link
Contributor Author

@jonahwilliams jonahwilliams Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

// See: https://github.com/flutter/flutter/issues/116168
auto compare_locations = [](ShaderStageIOSlot a, ShaderStageIOSlot b) {
return a.location < b.location;
};
std::sort(inputs_.begin(), inputs_.end(), compare_locations);

return true;
}

Expand Down