Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
141 changes: 0 additions & 141 deletions testing/impeller_vulkan_test_status.csv

This file was deleted.

22 changes: 3 additions & 19 deletions testing/run_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -513,19 +513,6 @@ def make_test(name, flags=None, extra_env=None):
)


def parse_impeller_vulkan_filter():
test_status_path = os.path.join(SCRIPT_DIR, 'impeller_vulkan_test_status.csv')
gtest_filter = '--gtest_filter="'
with open(test_status_path, 'r') as csvfile:
csvreader = csv.reader(csvfile)
next(csvreader) # Skip header.
for row in csvreader:
if row[1] == 'pass':
gtest_filter += '*%s:' % row[0]
gtest_filter += '"'
return gtest_filter


def run_engine_benchmarks(build_dir, executable_filter):
print('Running Engine Benchmarks.')

Expand Down Expand Up @@ -1209,20 +1196,17 @@ def main():
)

# Use this type to exclusively run impeller vulkan tests.
# TODO (https://github.com/flutter/flutter/issues/113961): Remove this once
# impeller vulkan tests are stable.
if 'impeller-vulkan' in types:
build_name = args.variant
try:
xvfb.start_virtual_x(build_name, build_dir)
vulkan_gtest_filter = parse_impeller_vulkan_filter()
gtest_flags = shuffle_flags
gtest_flags.append(vulkan_gtest_filter)
run_engine_executable(
build_dir,
'impeller_unittests',
engine_filter,
gtest_flags,
shuffle_flags + [
'--gtest_filter=-*/OpenGLES:Play/TypographerTest.MaybeHasOverlapping/Vulkan:Play/TypographerTest.GlyphAtlasWithLotsOfdUniqueGlyphSize/Vulkan',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create follow up issues for these 2 tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. Could you make a TODO here that links to the issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

],
coverage=args.coverage
)
finally:
Expand Down