Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Android] Lifecycle defaults to focused instead of unfocused #41875

Merged
auto-submit merged 1 commit into from
May 11, 2023
Merged

[Android] Lifecycle defaults to focused instead of unfocused #41875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shell/platform/android/io/flutter/embedding/engine/systemchannels/LifecycleChannel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public class LifecycleChannel {

private String lastAndroidState = "";
private String lastFlutterState = "";
private boolean lastFocus = false;
private boolean lastFocus = true;

@NonNull private final BasicMessageChannel<String> channel;

Expand Down
16 changes: 8 additions & 8 deletions ...latform/android/test/io/flutter/embedding/engine/systemchannels/LifecycleChannelTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,29 +31,29 @@ public void lifecycleChannel_handlesResumed() {
lifecycleChannel.appIsResumed();
ArgumentCaptor<String> stringArgumentCaptor = ArgumentCaptor.forClass(String.class);
verify(mockChannel, times(1)).send(stringArgumentCaptor.capture());
assertEquals("AppLifecycleState.inactive", stringArgumentCaptor.getValue());
assertEquals("AppLifecycleState.resumed", stringArgumentCaptor.getValue());

lifecycleChannel.aWindowIsFocused();
lifecycleChannel.noWindowsAreFocused();
stringArgumentCaptor = ArgumentCaptor.forClass(String.class);
verify(mockChannel, times(2)).send(stringArgumentCaptor.capture());
assertEquals("AppLifecycleState.resumed", stringArgumentCaptor.getValue());
assertEquals("AppLifecycleState.inactive", stringArgumentCaptor.getValue());

lifecycleChannel.noWindowsAreFocused();
lifecycleChannel.aWindowIsFocused();
stringArgumentCaptor = ArgumentCaptor.forClass(String.class);
verify(mockChannel, times(3)).send(stringArgumentCaptor.capture());
assertEquals("AppLifecycleState.inactive", stringArgumentCaptor.getValue());
assertEquals("AppLifecycleState.resumed", stringArgumentCaptor.getValue());

// Stays inactive, so no event is sent.
lifecycleChannel.appIsInactive();
verify(mockChannel, times(3)).send(any(String.class));
verify(mockChannel, times(4)).send(any(String.class));

// Stays inactive, so no event is sent.
lifecycleChannel.appIsResumed();
verify(mockChannel, times(3)).send(any(String.class));
verify(mockChannel, times(5)).send(any(String.class));

lifecycleChannel.aWindowIsFocused();
stringArgumentCaptor = ArgumentCaptor.forClass(String.class);
verify(mockChannel, times(4)).send(stringArgumentCaptor.capture());
verify(mockChannel, times(5)).send(stringArgumentCaptor.capture());
assertEquals("AppLifecycleState.resumed", stringArgumentCaptor.getValue());
}

Expand Down