This repository was archived by the owner on Feb 25, 2025. It is now read-only.
ColorFilterLayer clips to its paint bounds #41745
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes use of staging flag skia_use_legacy_layer_bounds, and preserves previous behavior for ColorFilterLayers that affect transparent black by clipping before the saveLayer() to prevent the layer from changing all transparent black pixels on the canvas. Adds a unit test to make sure the display list is modified appropriately in that case.
https://bugs.chromium.org/p/skia/issues/detail?id=12083
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.