Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@lhkbob
Copy link
Contributor

@lhkbob lhkbob commented May 4, 2023

Removes use of staging flag skia_use_legacy_layer_bounds, and preserves previous behavior for ColorFilterLayers that affect transparent black by clipping before the saveLayer() to prevent the layer from changing all transparent black pixels on the canvas. Adds a unit test to make sure the display list is modified appropriately in that case.

https://bugs.chromium.org/p/skia/issues/detail?id=12083

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

lhkbob added 7 commits May 5, 2023 13:51
Removes use of staging flag skia_use_legacy_layer_bounds, and preserves previous behavior for ColorFilterLayers that affect transparent black by clipping before the saveLayer() to prevent the layer from changing all transparent black pixels on the canvas. Adds a unit test to make sure the display list is modified appropriately in that case.
@lhkbob lhkbob force-pushed the colorfilter-layer-bounds branch from 5a52d38 to bde54dd Compare May 5, 2023 17:52
@lhkbob
Copy link
Contributor Author

lhkbob commented May 11, 2023

Closing this PR in favor of #41940, which just removes the staging flag and does no additional workaround to try and match legacy behavior. We can come back to this and CFLayer clipping if necessary.

@lhkbob lhkbob closed this May 11, 2023
@lhkbob lhkbob deleted the colorfilter-layer-bounds branch January 5, 2024 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant