This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Web+Linux] Fix pressing Meta keys throws #41694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Generally looks good. Can we limit this behavior on Linux? Generally I'd like the exception rules to be as strict as possible unless unnecessary. (Also if this rule is too loose, doesn't it make non-Linux Web app generate fewer events? |
bleroux
force-pushed
the
fix_web_linux_meta_key_not_reflected_in_metaState
branch
from
81a2e81 to
7a4b75f
Compare
Contributor
Author
Sure, that makes sense, I updated the PR to limit this behavior to Linux. |
dkwingsmt
approved these changes
May 12, 2023
Contributor
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
LGTM, thanks for taking care of it!
bleroux
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 13, 2023
flutter/engine@502e1eb...12e436d 2023-05-13 [email protected] Roll Fuchsia Mac SDK from rO5qs4MpN6WfJcu64... to oc2gdx4PWYT-K7XQ9... (flutter/engine#42000) 2023-05-12 [email protected] Roll Skia from 64bdd87fadfe to 6a4e29cbd73b (2 revisions) (flutter/engine#41999) 2023-05-12 [email protected] [Impeller] Remove a debug log from the Vulkan render pass (flutter/engine#41987) 2023-05-12 [email protected] Roll Dart SDK from 858f83d6d993 to 2a285d87f5d7 (2 revisions) (flutter/engine#41997) 2023-05-12 [email protected] [Impeller] Ignore the Z basis when scaling text (flutter/engine#41995) 2023-05-12 [email protected] Roll Skia from 539fb10d7cfb to 64bdd87fadfe (18 revisions) (flutter/engine#41993) 2023-05-12 [email protected] [web] Cleaner output on LUCI (flutter/engine#41989) 2023-05-12 [email protected] [Web+Linux] Fix pressing Meta keys throws (flutter/engine#41694) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from rO5qs4MpN6Wf to oc2gdx4PWYT- If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…6725) flutter/engine@502e1eb...12e436d 2023-05-13 [email protected] Roll Fuchsia Mac SDK from rO5qs4MpN6WfJcu64... to oc2gdx4PWYT-K7XQ9... (flutter/engine#42000) 2023-05-12 [email protected] Roll Skia from 64bdd87fadfe to 6a4e29cbd73b (2 revisions) (flutter/engine#41999) 2023-05-12 [email protected] [Impeller] Remove a debug log from the Vulkan render pass (flutter/engine#41987) 2023-05-12 [email protected] Roll Dart SDK from 858f83d6d993 to 2a285d87f5d7 (2 revisions) (flutter/engine#41997) 2023-05-12 [email protected] [Impeller] Ignore the Z basis when scaling text (flutter/engine#41995) 2023-05-12 [email protected] Roll Skia from 539fb10d7cfb to 64bdd87fadfe (18 revisions) (flutter/engine#41993) 2023-05-12 [email protected] [web] Cleaner output on LUCI (flutter/engine#41989) 2023-05-12 [email protected] [Web+Linux] Fix pressing Meta keys throws (flutter/engine#41694) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from rO5qs4MpN6Wf to oc2gdx4PWYT- If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes Meta keys throwing exception on Chrome Linux.
The assertions throws because the DOM event sent when Meta keys is pressed is not coherent when Meta is the only pressed key.
Related Issue
Fixes flutter/flutter#125672
Tests
Adds 1 test.