Revert "[embedder] embedder external view adopt DisplayListEmbedderViewSlice"

ci/licenses_golden/excluded_files

@@ -207,7 +207,6 @@
 ../../../flutter/shell/common/animator_unittests.cc
 ../../../flutter/shell/common/canvas_spy_unittests.cc
 ../../../flutter/shell/common/context_options_unittests.cc
-../../../flutter/shell/common/dl_op_spy_unittests.cc
 ../../../flutter/shell/common/engine_unittests.cc
 ../../../flutter/shell/common/fixtures
 ../../../flutter/shell/common/input_events_unittests.cc

ci/licenses_golden/licenses_flutter

@@ -2113,8 +2113,6 @@ ORIGIN: ../../../flutter/shell/common/display.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/shell/common/display.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/shell/common/display_manager.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/shell/common/display_manager.h + ../../../flutter/LICENSE
-ORIGIN: ../../../flutter/shell/common/dl_op_spy.cc + ../../../flutter/LICENSE
-ORIGIN: ../../../flutter/shell/common/dl_op_spy.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/shell/common/engine.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/shell/common/engine.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/shell/common/pipeline.cc + ../../../flutter/LICENSE
@@ -4703,8 +4701,6 @@ FILE: ../../../flutter/shell/common/display.cc
 FILE: ../../../flutter/shell/common/display.h
 FILE: ../../../flutter/shell/common/display_manager.cc
 FILE: ../../../flutter/shell/common/display_manager.h
-FILE: ../../../flutter/shell/common/dl_op_spy.cc
-FILE: ../../../flutter/shell/common/dl_op_spy.h
 FILE: ../../../flutter/shell/common/engine.cc
 FILE: ../../../flutter/shell/common/engine.h
 FILE: ../../../flutter/shell/common/pipeline.cc

display_list/dl_blend_mode.h

@@ -9,7 +9,8 @@ namespace flutter {
 
 /// A enum define the blend mode.
 /// Blends are operators that take in two colors (source, destination) and
-/// return a new color. Many of these operate the same on all 4
+/// return a new color. Blends are operators that take in two colors (source,
+/// destination) and return a new color. Many of these operate the same on all 4
 /// components: red, green, blue, alpha. For these, we just document what
 /// happens to one component, rather than naming each one separately. Different
 /// color types might have different representations for color components:

flow/embedded_views.cc

@@ -30,18 +30,6 @@ void DisplayListEmbedderViewSlice::render_into(DlCanvas* canvas) {
   canvas->DrawDisplayList(display_list_);
 }
 
-void DisplayListEmbedderViewSlice::dispatch(DlOpReceiver& receiver) {
-  display_list_->Dispatch(receiver);
-}
-
-bool DisplayListEmbedderViewSlice::is_empty() {
-  return display_list_->bounds().isEmpty();
-}
-
-bool DisplayListEmbedderViewSlice::recording_ended() {
-  return builder_ == nullptr;
-}
-
 void ExternalViewEmbedder::SubmitFrame(GrDirectContext* context,
                                        std::unique_ptr<SurfaceFrame> frame) {
   frame->Submit();

flow/embedded_views.h

@@ -352,9 +352,6 @@ class DisplayListEmbedderViewSlice : public EmbedderViewSlice {
   std::list<SkRect> searchNonOverlappingDrawnRects(
       const SkRect& query) const override;
   void render_into(DlCanvas* canvas) override;
-  void dispatch(DlOpReceiver& receiver);
-  bool is_empty();
-  bool recording_ended();
 
  private:
   std::unique_ptr<DisplayListBuilder> builder_;

shell/common/BUILD.gn

@@ -77,8 +77,6 @@ source_set("common") {
     "display.h",
     "display_manager.cc",
     "display_manager.h",
-    "dl_op_spy.cc",
-    "dl_op_spy.h",
     "engine.cc",
     "engine.h",
     "pipeline.cc",
@@ -289,7 +287,6 @@ if (enable_unittests) {
       "animator_unittests.cc",
       "canvas_spy_unittests.cc",
       "context_options_unittests.cc",
-      "dl_op_spy_unittests.cc",
       "engine_unittests.cc",
       "input_events_unittests.cc",
       "persistent_cache_unittests.cc",