Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@bernaferrari
Copy link
Contributor

@bernaferrari bernaferrari commented Apr 2, 2023

Kind of surprising, but part of #40567.

There is a test there that applies to this, and even though I can duplicate the test and fix for SemanticsAction, if this is used as an enum, it can be an enum.

Right? Let's see if tests pass.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@bernaferrari
Copy link
Contributor Author

This is confusing, theoretically it could be possible, but the class is weird. It is used as an enum, but its parents (EngineAccessibilityFeaturesBuilder) are used "correctly". Yet, _updateAccessibilityFeatures still expects the value to be passed in a correct way. My test didn't work, I'll duplicate the method in the other branch.

@bernaferrari bernaferrari changed the title Convert AccessibilityFeatures to enum [Experiment] Convert AccessibilityFeatures to enum Apr 2, 2023
@flutter-dashboard flutter-dashboard bot added the embedder Related to the embedder API label Apr 2, 2023
@bernaferrari bernaferrari deleted the AccessibilityFeatures branch April 4, 2023 04:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

embedder Related to the embedder API needs tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant