Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Don't use waitUntilScheduled on iOS #40768

Merged
auto-submit merged 3 commits into from
Mar 30, 2023
Merged

[Impeller] Don't use waitUntilScheduled on iOS #40768

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
965877b
[Impeller] Don't use waitUntilScheduled on iOS
bdero Mar 29, 2023
befea90
Add comment
bdero Mar 29, 2023
1530b27
Merge branch 'main' into bdero/waitios
bdero Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions impeller/renderer/backend/metal/command_buffer_mtl.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,9 @@ static bool LogMTLCommandBufferErrorIfPresent(id<MTLCommandBuffer> buffer) {
}

[buffer_ commit];
#if (FML_OS_MACOSX || FML_OS_IOS_SIMULATOR)
Copy link
Contributor

@dnfield dnfield Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment with some context about what we know and have tried to date, and what the failure mode is and how to trigger it.

Copy link
Member Author

@bdero bdero Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrighty, done.

Copy link
Contributor

@dnfield dnfield Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any instructions on how to reproduce the issue seen? E.g. Run wonderous app on a simulator on an arm mac host?

Copy link
Member

@chinmaygarde chinmaygarde Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thats pretty much exactly it.

[buffer_ waitUntilScheduled];
#endif
buffer_ = nil;
return true;
}
Expand Down