Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Mar 22, 2023

Description

This adds app lifecycle notification for macOS and Linux, and adds a new hidden state to the AppLifecycleState enum.

To be functional, this needs a corresponding framework change: flutter/flutter#123274

Related Issues

Tests

  • Added tests for state changes.

@flutter-dashboard flutter-dashboard bot added embedder Related to the embedder API platform-ios platform-macos platform-web Code specifically for the web engine labels Mar 22, 2023
@gspencergoog gspencergoog force-pushed the app_lifecycle branch 2 times, most recently from 63c19ad to b6ce29f Compare April 3, 2023 19:06
@gspencergoog gspencergoog force-pushed the app_lifecycle branch 7 times, most recently from 5bb600a to eddb242 Compare April 8, 2023 00:22
@gspencergoog gspencergoog changed the title Adding app lifecycle notification Adding app lifecycle notification for macOS, and hidden state. Apr 8, 2023
@gspencergoog gspencergoog force-pushed the app_lifecycle branch 7 times, most recently from c8fb1db to 137cf1b Compare April 13, 2023 23:15
@gspencergoog gspencergoog changed the title Adding app lifecycle notification for macOS, and hidden state. Adding app lifecycle notification for macOS and Linux, add hidden state. Apr 13, 2023
@gspencergoog gspencergoog force-pushed the app_lifecycle branch 2 times, most recently from c968921 to 033ce0a Compare April 14, 2023 20:31
@gspencergoog gspencergoog added autosubmit Merge PR when tree becomes green via auto submit App and removed will affect goldens labels May 26, 2023
@auto-submit auto-submit bot merged commit 9fd0082 into flutter:main May 26, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 27, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 27, 2023
…127738)

flutter/engine@795db50...3426cb8

2023-05-27 [email protected] Roll Dart SDK from 14162b5f5a1a to e0caea366989 (3 revisions) (flutter/engine#42376)
2023-05-26 [email protected] Roll Fuchsia Mac SDK from c6-zqvlx2YtyGwGzJ... to f94C9eArSWIUjOTM6... (flutter/engine#42367)
2023-05-26 [email protected] Adding app lifecycle notification for macOS and Linux, add `hidden` state. (flutter/engine#40542)
2023-05-26 [email protected] Roll Dart SDK from bc65e3f5efa0 to 14162b5f5a1a (3 revisions) (flutter/engine#42366)
2023-05-26 [email protected] Roll Fuchsia Linux SDK from 9aZkaKhX4GslPUnbX... to 2-z8tqXe3ZkKqeb3e... (flutter/engine#42365)
2023-05-26 [email protected] Fix ci yaml roller caused by incorrect format (flutter/engine#42364)
2023-05-26 [email protected] [macOS] Extract more PlatformViewMutator code (flutter/engine#42361)
2023-05-26 [email protected] Enable bugprone-unchecked-optional-access, disable in files with warnings (flutter/engine#42359)
2023-05-26 [email protected] Roll Skia from ac897edeb16a to 8d475ae01f09 (9 revisions) (flutter/engine#42363)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 9aZkaKhX4Gsl to 2-z8tqXe3ZkK
  fuchsia/sdk/core/mac-amd64 from c6-zqvlx2Yty to f94C9eArSWIU

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zanderso added a commit that referenced this pull request May 27, 2023
auto-submit bot pushed a commit that referenced this pull request May 30, 2023
…hidden` state." (#40542) (#42418)

## Description

This reverts commit 57e491a to re-land #40542 to fix the lint warning which caused the original PR to be reverted (the lint warnings were turned on after the original was landed, which is why it wasn't caught earlier).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App embedder Related to the embedder API platform-android platform-ios platform-linux platform-macos platform-web Code specifically for the web engine platform-windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants