Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Build Impeller Vulkan backend on Windows #40196

Merged
bdero merged 2 commits into from
Mar 10, 2023
Merged

[Impeller] Build Impeller Vulkan backend on Windows #40196

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d56932
[Impeller] Build Impeller Vulkan backend on Windows
bdero Mar 9, 2023
252af29
Remove mem requirements 2
bdero Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion impeller/renderer/backend/vulkan/allocator_vk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ class AllocatedTextureSourceVK final : public TextureSourceVK {
&allocation_info //
)};
if (result != vk::Result::eSuccess) {
VALIDATION_LOG << "Unable to allocation Vulkan Image: "
VALIDATION_LOG << "Unable to allocate Vulkan Image: "
<< vk::to_string(result);
return;
}
Expand Down
4 changes: 3 additions & 1 deletion impeller/renderer/backend/vulkan/context_vk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ VKAPI_ATTR VkBool32 VKAPI_CALL DebugUtilsMessengerCallback(
}

const auto prefix = impeller::vk::to_string(
impeller::vk::DebugUtilsMessageSeverityFlagBitsEXT{severity});
impeller::vk::DebugUtilsMessageSeverityFlagBitsEXT(severity));
// Just so that the log doesn't say FML_DCHECK(false).
constexpr bool kVulkanValidationFailure = false;
FML_DCHECK(kVulkanValidationFailure)
Expand Down Expand Up @@ -79,6 +79,8 @@ bool HasValidationLayers() {

static std::set<std::string> kRequiredDeviceExtensions = {
VK_KHR_SWAPCHAIN_EXTENSION_NAME,
// Used by VMA; part of Vulkan 1.1 core.
VK_KHR_GET_MEMORY_REQUIREMENTS_2_EXTENSION_NAME,
#if FML_OS_MACOSX
"VK_KHR_portability_subset", // For Molten VK. No define present in header.
#endif
Expand Down
6 changes: 3 additions & 3 deletions impeller/renderer/compute_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ TEST_P(ComputeTest, CanCreateComputePass) {
CS::Info info{.count = kCount};
CS::Input0<kCount> input_0;
CS::Input1<kCount> input_1;
for (uint i = 0; i < kCount; i++) {
for (size_t i = 0; i < kCount; i++) {
input_0.elements[i] = Vector4(2.0 + i, 3.0 + i, 4.0 + i, 5.0 * i);
input_1.elements[i] = Vector4(6.0, 7.0, 8.0, 9.0);
}
Expand Down Expand Up @@ -139,13 +139,13 @@ TEST_P(ComputeTest, MultiStageInputAndOutput) {

CS1::Input<kCount1> input_1;
input_1.count = kCount1;
for (uint i = 0; i < kCount1; i++) {
for (size_t i = 0; i < kCount1; i++) {
input_1.elements[i] = i;
}

CS2::Input<kCount2> input_2;
input_2.count = kCount2;
for (uint i = 0; i < kCount2; i++) {
for (size_t i = 0; i < kCount2; i++) {
input_2.elements[i] = i;
}

Expand Down
2 changes: 1 addition & 1 deletion impeller/tools/impeller.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ declare_args() {
impeller_enable_opengles = is_mac || is_linux || is_win || is_android

# Whether the Vulkan backend is enabled.
impeller_enable_vulkan = is_mac || is_linux || is_android
impeller_enable_vulkan = is_mac || is_linux || is_win || is_android

# Whether to use a prebuilt impellerc.
# If this is the empty string, impellerc will be built.
Expand Down