-
Notifications
You must be signed in to change notification settings - Fork 6k
restructure DL sources into sub-directories and new file naming conventions #40157
Conversation
|
This will likely fail once the previous reorg of the DL sources is reverted: #40161 |
|
Note from triage: It looks like the tests are failing and there's no issue that describes the benefit of this PR. Consider putting this in draft state? |
|
The conflicts should go away after Jims revert relands. The presub failures on the licenses are real though. |
|
This was dependent on another PR that had to be reverted. I'll have to rebase this one when the other relands, but this is otherwise ready to go (modulo some sorting of the license files). |
|
sgtm |
|
This PR will eventually be landed, but it will need to be rebased on top of the "Sequester all Skia interactions" PR which has been landed and reverted a few times. I'm turning this PR into a draft until that other PR sticks the landing, at which point I'll do hopefully one last rebase of this PR on top of that and submit it for review. |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
0436bee to
1795919
Compare
The changes here should be 90% moving files around and adjusting #include statements to match, but there were a couple of housekeeping changes made in the name of being more transparent about Skia usage - mainly moving the "include all" types.h header file into the skia directory and forcing all of the other files in the main DL source directories explicitly include any Skia types they still depend on. That should help with finding where we can de-skia-fy in future passes.