Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@flar
Copy link
Contributor

@flar flar commented Mar 9, 2023

The changes here should be 90% moving files around and adjusting #include statements to match, but there were a couple of housekeeping changes made in the name of being more transparent about Skia usage - mainly moving the "include all" types.h header file into the skia directory and forcing all of the other files in the main DL source directories explicitly include any Skia types they still depend on. That should help with finding where we can de-skia-fy in future passes.

@flar
Copy link
Contributor Author

flar commented Mar 9, 2023

This will likely fail once the previous reorg of the DL sources is reverted: #40161

@camsim99
Copy link
Contributor

camsim99 commented Mar 9, 2023

Note from triage: It looks like the tests are failing and there's no issue that describes the benefit of this PR. Consider putting this in draft state?

@chinmaygarde
Copy link
Member

chinmaygarde commented Mar 9, 2023

The conflicts should go away after Jims revert relands. The presub failures on the licenses are real though.

@flar
Copy link
Contributor Author

flar commented Mar 10, 2023

This was dependent on another PR that had to be reverted. I'll have to rebase this one when the other relands, but this is otherwise ready to go (modulo some sorting of the license files).

@chinmaygarde
Copy link
Member

sgtm

@flar flar marked this pull request as draft March 15, 2023 18:58
@flar
Copy link
Contributor Author

flar commented Mar 15, 2023

This PR will eventually be landed, but it will need to be rebased on top of the "Sequester all Skia interactions" PR which has been landed and reverted a few times. I'm turning this PR into a draft until that other PR sticks the landing, at which point I'll do hopefully one last rebase of this PR on top of that and submit it for review.

@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

@flar flar force-pushed the DL-tree-restructure branch from 0436bee to 1795919 Compare March 20, 2023 22:40
@flar flar marked this pull request as ready for review March 21, 2023 02:10
@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit auto-submit bot merged commit ee6969d into flutter:main Mar 21, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants