This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Fix multi-function compute #39603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
added
e: impeller
autosubmit
dnfield
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 14, 2023
…120656) * 8cd648d1d Roll Dart SDK from f80c5db8736a to ea59504416a8 (1 revision) (flutter/engine#39594) * 9ac09ced1 [Impeller] Fix unsafe access for clip stencil coverage (flutter/engine#39595) * 99a81a81f Add support for double tap action from Apple Pencil 2 (flutter/engine#39267) * 89d41d13e Add unique device id for trackpad on web (flutter/engine#39260) * f7dfb2b63 remove use of SkCanvas and DLCanvasRecorder from ui.Canvas native code (flutter/engine#39599) * c2e165e36 Fix multi-function compute (flutter/engine#39603) * c4f51bc78 Revert "Add support for double tap action from Apple Pencil 2 (#39267)" (flutter/engine#39607)
0xZOne
pushed a commit
to 0xZOne/engine
that referenced
this pull request
Feb 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding multiple kernels to a single compute pass was only running the last one - the call to actually dispatch the method was nested improperly and only being invoked for the final command in the buffer.
Adds a test covering this situation, including sharing data between the kernel functions and verifying the output of both.