Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Update engine v2 builds to remove gclient_custom_var support #37494

Closed
whesse wants to merge 1 commit into from
Closed

Update engine v2 builds to remove gclient_custom_var support #37494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions ci/builders/linux_android_aot_engine.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@
"device_type=none",
"os=Linux"
],
"gclient_custom_vars": {
Copy link
Contributor

@godofredoc godofredoc Nov 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change! would it be possible to rename to gclient_variables instead?

"download_android_deps": false
},
"gn": [
"--runtime-mode",
"profile",
Expand Down Expand Up @@ -58,9 +55,6 @@
"device_type=none",
"os=Linux"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"release",
Expand Down Expand Up @@ -98,9 +92,6 @@
"device_type=none",
"os=Linux"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"release",
Expand Down Expand Up @@ -136,9 +127,6 @@
"device_type=none",
"os=Linux"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--android",
"--runtime-mode",
Expand Down Expand Up @@ -175,9 +163,6 @@
"device_type=none",
"os=Linux"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"profile",
Expand Down Expand Up @@ -214,9 +199,6 @@
"device_type=none",
"os=Linux"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"release",
Expand Down
12 changes: 0 additions & 12 deletions ci/builders/linux_android_debug_engine.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@
"device_type=none",
"os=Linux"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--android",
"--unoptimized",
Expand Down Expand Up @@ -148,9 +145,6 @@
"device_type=none",
"os=Linux"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--android",
"--android-cpu=arm64",
Expand Down Expand Up @@ -183,9 +177,6 @@
"device_type=none",
"os=Linux"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--android",
"--android-cpu=x86",
Expand Down Expand Up @@ -218,9 +209,6 @@
"device_type=none",
"os=Linux"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--android",
"--android-cpu=x64",
Expand Down
9 changes: 0 additions & 9 deletions ci/builders/linux_arm_host_engine.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@
"device_type=none",
"os=Linux"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"profile",
Expand Down Expand Up @@ -53,9 +50,6 @@
"device_type=none",
"os=Linux"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"debug",
Expand Down Expand Up @@ -91,9 +85,6 @@
"device_type=none",
"os=Linux"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"release",
Expand Down
15 changes: 0 additions & 15 deletions ci/builders/linux_host_engine.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
"device_type=none",
"os=Linux"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"debug",
Expand All @@ -31,9 +28,6 @@
"device_type=none",
"os=Linux"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"debug",
Expand Down Expand Up @@ -88,9 +82,6 @@
"device_type=none",
"os=Linux"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"debug",
Expand Down Expand Up @@ -128,9 +119,6 @@
"device_type=none",
"os=Linux"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"profile",
Expand Down Expand Up @@ -178,9 +166,6 @@
"device_type=none",
"os=Linux"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"release",
Expand Down
18 changes: 0 additions & 18 deletions ci/builders/mac_android_aot_engine.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@
"os=Mac-12",
"cpu=x86"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"profile",
Expand Down Expand Up @@ -50,9 +47,6 @@
"os=Mac-12",
"cpu=x86"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"profile",
Expand Down Expand Up @@ -85,9 +79,6 @@
"os=Mac-12",
"cpu=x86"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"profile",
Expand Down Expand Up @@ -120,9 +111,6 @@
"os=Mac-12",
"cpu=x86"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"release",
Expand Down Expand Up @@ -154,9 +142,6 @@
"os=Mac-12",
"cpu=x86"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"release",
Expand Down Expand Up @@ -189,9 +174,6 @@
"os=Mac-12",
"cpu=x86"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"release",
Expand Down
18 changes: 0 additions & 18 deletions ci/builders/mac_host_engine.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@
"os=Mac-12",
"cpu=x86"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"debug",
Expand Down Expand Up @@ -60,9 +57,6 @@
"os=Mac-12",
"cpu=x86"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"profile",
Expand Down Expand Up @@ -113,9 +107,6 @@
"os=Mac-12",
"cpu=x86"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"release",
Expand Down Expand Up @@ -152,9 +143,6 @@
"os=Mac-12",
"cpu=x86"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--mac",
"--mac-cpu",
Expand Down Expand Up @@ -191,9 +179,6 @@
"os=Mac-12",
"cpu=x86"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--mac",
"--mac-cpu",
Expand Down Expand Up @@ -229,9 +214,6 @@
"os=Mac-12",
"cpu=x86"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--mac",
"--mac-cpu",
Expand Down
9 changes: 0 additions & 9 deletions ci/builders/windows_host_engine.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@
"device_type=none",
"os=Windows-10"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"debug",
Expand Down Expand Up @@ -74,9 +71,6 @@
"device_type=none",
"os=Windows-10"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"profile",
Expand Down Expand Up @@ -108,9 +102,6 @@
"device_type=none",
"os=Windows-10"
],
"gclient_custom_vars": {
"download_android_deps": false
},
"generators": {},
"gn": [
"--runtime-mode",
Expand Down