Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Log to stdout on all platforms except Android #3739

Merged
cbracken merged 2 commits into from
Jun 5, 2017
Merged

Log to stdout on all platforms except Android #3739

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a571f64
Log to stdout on all platforms except Android
cbracken Jun 5, 2017
c256afd
Punctuation
cbracken Jun 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/ui/dart_runtime_hooks.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,9 @@ void Logger_PrintString(Dart_NativeArguments args) {
// Write to the logcat on Android.
const char* tag = Settings::Get().log_tag.c_str();
__android_log_print(ANDROID_LOG_INFO, tag, "%.*s", (int)length, chars);
#elif defined(__APPLE__) || defined(OS_LINUX)
// On iOS and in flutter_tester (on both macOS and Linux, write directly to
// stdout. On iOS, this is redirected to ASL via
#else
// On Fuchsia, iOS and in flutter_tester (on both macOS and Linux, write
Copy link
Contributor

@Hixie Hixie Jun 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing close paren

Copy link
Member Author

@cbracken cbracken Jun 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

// directly to stdout. On iOS, this is redirected to ASL via
// RedirectIOConnectionsToSyslog in platform_mac.mm.
// TODO(cbracken) replace with dedicated (non-stdout) logging on iOS.
Copy link
Contributor

@Hixie Hixie Jun 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing colon after ) in TODO

Copy link
Member Author

@cbracken cbracken Jun 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

fwrite(chars, 1, length, stdout);
Expand Down