-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use git exec candidate list on all platforms for build #34294
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build/git_revision.py now uses a git executable name search list on all platforms, avoiding issues with some Windows installations.
Is a similar fix also needed in |
flutter_tester executable on Windows
Reason: Added to incorrect branch This reverts commit 1b0da56.
@zanderso you're correct, I wasn't sure whether that fix is relevant to the topic (i.e. build on windows). Anyway I added the modification to setup.py as well. |
zanderso
approved these changes
Jun 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 28, 2022
loic-sharma
added a commit
that referenced
this pull request
Jul 22, 2022
This reverts commit bc87d30.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build/git_revision.py
now uses a git executable name search list on all platforms, avoiding issues with some Windows installations.Linked issues
Impact on flutter/tests repo
This PR does not affect the flutter/tests repo.
Pre-launch Checklist
///
).