Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git exec candidate list on all platforms for build #34294

Merged
merged 7 commits into from
Jun 28, 2022
Merged

Use git exec candidate list on all platforms for build #34294

merged 7 commits into from
Jun 28, 2022

Conversation

mtolmacs
Copy link
Contributor

@mtolmacs mtolmacs commented Jun 25, 2022

build/git_revision.py now uses a git executable name search list on all platforms, avoiding issues with some Windows installations.

Linked issues

Impact on flutter/tests repo

This PR does not affect the flutter/tests repo.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

mtolmacs added 3 commits June 25, 2022 19:30
build/git_revision.py now uses a git executable name search list on all
platforms, avoiding issues with some Windows installations.
@mtolmacs mtolmacs marked this pull request as ready for review June 26, 2022 10:31
@chinmaygarde chinmaygarde requested a review from zanderso June 27, 2022 18:10
@zanderso
Copy link
Member

Is a similar fix also needed in tools/githooks/setup.py?

@mtolmacs
Copy link
Contributor Author

@zanderso you're correct, I wasn't sure whether that fix is relevant to the topic (i.e. build on windows). Anyway I added the modification to setup.py as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Engine configuration phase on Windows cannot find git.bat in git_revision.py with some git installations
2 participants