Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@bdero
Copy link
Member

@bdero bdero commented May 31, 2022

Depends on #33706.

  • Make high DPI work in the Metal playground. Previously, the drawable size was always ending up with the window size in screen coordinates.
  • Add high DPI support to the ImGui Impeller backend. Conveniently, ImGui keeps track of a content scale value, and platform backends like imgui_impl_glfw already set it correctly, so there's no need for extra params on e.g. ImGui_ImplImpeller_RenderDrawData(). :)
  • Make all renderer/entity unittests and some some aiks/displaylist unittest (the ones that use ImGui) resolution independent.
  • Smoke tested this for GLES and Metal for macOS + GLES on Windows.

@bdero bdero force-pushed the bdero/fix-fb-mapping branch from a4dc723 to d2dd579 Compare May 31, 2022 08:57
@bdero bdero force-pushed the bdero/fix-fb-mapping branch from d2dd579 to b6d9110 Compare May 31, 2022 18:35
@bdero bdero merged commit 320c8ae into flutter:main May 31, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 31, 2022
…; make high DPI work in the Metal playground; make playground tests respect content scale (flutter/engine#33708)
@chinmaygarde
Copy link
Member

Fixes flutter/flutter#104863

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 31, 2022
…; make high DPI work in the Metal playground; make playground tests respect content scale (flutter/engine#33708)
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
…igh DPI work in the Metal playground; make playground tests respect content scale (flutter#33708)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants