Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Migrate Flutter Web DOM usage to JS static interop - 12. #33241

Merged
merged 3 commits into from
May 13, 2022

Conversation

joshualitt
Copy link
Contributor

This is CL 12 in a series of CLs to migrate Flutter Web DOM usage to the new JS static interop API.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label May 10, 2022
@joshualitt joshualitt force-pushed the html_12 branch 2 times, most recently from 4a667af to 4d2295a Compare May 10, 2022 23:58
@joshualitt joshualitt requested a review from yjbanov May 11, 2022 16:55
@joshualitt
Copy link
Contributor Author

@yjbanov ptal. Please only look at CL 12:
4d2295a

Or using compare: joshualitt/engine@html_11...joshualitt:html_12

Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joshualitt joshualitt merged commit 7956603 into flutter:main May 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2022
joshualitt added a commit that referenced this pull request May 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2022
joshualitt added a commit that referenced this pull request May 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2022
zanderso pushed a commit to flutter/flutter that referenced this pull request May 13, 2022
* c4b899f Roll dart sdk to 7b24ff4d92e2d2136020fc5bedadfe7025861510 (flutter/engine#33309)

* 7956603 [web] Migrate Flutter Web DOM usage to JS static interop - 12. (flutter/engine#33241)

* 1d0c2ae Roll Skia from 1e43dce386c9 to f6e31bf1dcfb (6 revisions) (flutter/engine#33320)

* ed5a2fe Roll Skia from f6e31bf1dcfb to 69fecd6c2d85 (1 revision) (flutter/engine#33322)

* 10e0e15 Revert "[web] Migrate Flutter Web DOM usage to JS static interop - 12. (#33241)" (flutter/engine#33321)

* fix local tests

Co-authored-by: Jonah Williams <[email protected]>
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants