This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] do not allocate canvases just for text #32744
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Only paint text into canvas if there is already a canvas. Do not create a canvas just for text.
This PR includes some clean-ups:
CanvasPool.isEmpty/isNotEmptywithhasCanvas(the pool can be full of canvases and still returntruefromisEmpty, which is surprising).drawOnCanvastocanDrawOnCanvas.Fixes flutter/flutter#96498
Lands #30804, which had some issues with golden files.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.