Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Animated PNG demuxer #31098

Merged
merged 11 commits into from
Feb 10, 2023
Merged

Add Animated PNG demuxer #31098

merged 11 commits into from
Feb 10, 2023

Conversation

bdero
Copy link
Member

@bdero bdero commented Jan 27, 2022

Adds a multiframe image decoder that demuxes APNG streams into regular PNG-compliant streams. The actual color decoding is done by Skia's existing PNG decoder.

A single lazy pass is performed over the full stream as the frames are decoded for the first time.

Resolves flutter/flutter#37247.

@bdero bdero added affects: engine Work in progress (WIP) Not ready (yet) for review! labels Jan 27, 2022
@bdero bdero mentioned this pull request Jan 27, 2022
Merged
@bdero
Copy link
Member Author

bdero commented Feb 8, 2022

At this point, we have pretty reasonable coverage of the spec. Both blending ops and 2/3 of the dispose ops are supported (APNG_DISPOSE_OP_PREVIOUS is the one that's missing at the moment). I think the vast majority of real world APNGs display correctly now.

Screen.Recording.2022-02-08.at.1.57.35.PM.mov

(Tests are this and this)

Known issues:

  • There's a multiframecodec bug where stopped animations always advance by 1 frame when off-screen images reappear.
  • APNG_DISPOSE_OP_PREVIOUS behaves like APNG_DISPOSE_OP_BACKGROUND.
  • Ancillary chunks that can possibly transform frame regions are ignored -- I think these cases are somewhat pathological in practice and so I consider it out of scope for now.

@bdero bdero force-pushed the bdero/apng-decoder branch 2 times, most recently from b38251a to e324ba5 Compare February 11, 2022 01:03
@bdero bdero force-pushed the bdero/apng-decoder branch 2 times, most recently from 1427a39 to c2d23fb Compare February 17, 2022 20:49
@flutter-dashboard
Copy link

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

@toneyzeng
Copy link
Contributor

@bdero So happy to hear that you are doing for APNG, and what is the progress now?

@sveinbjornt
Copy link

What's the status on this?

@chinmaygarde
Copy link
Member

@bdero Is this still on your plate?

@bdero
Copy link
Member Author

bdero commented May 24, 2022

Yeah, this should be good to go as-is. Just need to swing around and add tests. The remaining validation TODOs aren't essential.

@everskies
Copy link

@bdero Super excited to see this come together! Is there anything else required besides a suite of tests to get this into the engine? I'd be more than willing to add tests once you're happy with the implementation

@chinmaygarde
Copy link
Member

Closing this as stale and there are conflicts. Please re-open if progress can be made.

@bdero bdero reopened this Oct 30, 2022
@bdero bdero force-pushed the bdero/apng-decoder branch 2 times, most recently from 19629bb to 14a8787 Compare October 30, 2022 04:55
@bdero bdero marked this pull request as draft October 30, 2022 05:18
@bdero bdero changed the title WIP: Add Animated PNG demuxer Add Animated PNG demuxer Oct 30, 2022
@skia-gold
Copy link

Gold has detected about 247 new digest(s) on patchset 12.
View them at https://flutter-engine-gold.skia.org/cl/github/31098

@bdero bdero marked this pull request as ready for review December 1, 2022 21:01
@bdero
Copy link
Member Author

bdero commented Dec 1, 2022

I haven't added tests for this yet, but the implementation for this is ready for review.

@bdero
Copy link
Member Author

bdero commented Dec 1, 2022 •
edited
Loading

Since the last time this was closed/reopened, Skia made the internal software rasterizing utilities private, so I had to reimplement this for frame compositing. Certain frame formats like greyscale textures are no longer supported because of that, but we can easily add those corner cases back in later.

@chinmaygarde
Copy link
Member

@jason-simmons I think you need to explicitly approve instead of adding an LGTM comment to make the presubs pass. I believe all the comments have been addressed. PTAL.

toneyzeng
toneyzeng reviewed Feb 7, 2023
View reviewed changes
lib/ui/painting/image_generator.h
@@ -80,7 +84,7 @@ class ImageGenerator {
/// @return Information about the given frame. If the image is
/// single-frame, a default result is returned.
/// @see `GetFrameCount`
virtual const FrameInfo GetFrameInfo(unsigned int frame_index) const = 0;
virtual const FrameInfo GetFrameInfo(unsigned int frame_index) = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the |const| modifier?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetFrameInfo requires decoding the image header as per the registry protocol, which is expected to have substantial side effects per the protocol.

@chinmaygarde
Copy link
Member

@bdero, this looks good to go. Can we land this? @toneyzeng has an open question though.

@bdero bdero merged commit b3e9642 into flutter:main Feb 10, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 10, 2023
@engine-flutter-autoroll
b3e9642c6 Add Animated PNG demuxer (flutter/engine#31098)
9423d96
@deckerst deckerst mentioned this pull request Feb 10, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 10, 2023
@engine-flutter-autoroll
b3e9642c6 Add Animated PNG demuxer (flutter/engine#31098)
7008445
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 10, 2023
@engine-flutter-autoroll
b3e9642c6 Add Animated PNG demuxer (flutter/engine#31098)
ec7d471
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 10, 2023
@engine-flutter-autoroll
b3e9642c6 Add Animated PNG demuxer (flutter/engine#31098)
a7a242d
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 10, 2023
@engine-flutter-autoroll
Roll Flutter Engine from add9e11edb66 to 4104eb5cbc40 (14 revisions) (#…
52ab299 
…120470)

* bf38bf6cf Bump to Chrome 111. (flutter/engine#39525)

* d76023b53 Roll Skia from 128d82c8931d to 59c9ef67fa34 (3 revisions) (flutter/engine#39529)

* da0e1463a Roll Skia from 59c9ef67fa34 to 4013995114e1 (2 revisions) (flutter/engine#39530)

* 5203b6ff6 Roll Skia from 4013995114e1 to 182d5daf78dc (1 revision) (flutter/engine#39531)

* b3e9642c6 Add Animated PNG demuxer (flutter/engine#31098)

* 54665882c [Impeller] Generate a Metal library symbols file for shader debugging. (flutter/engine#39532)

* 931bf7a47 Roll Skia from 182d5daf78dc to 299221eaa3a9 (1 revision) (flutter/engine#39533)

* 3ad331a1a Roll Fuchsia Mac SDK from s0lx1q5xbqV1jkRZM... to 86sd_NCGPMuQh08NX... (flutter/engine#39534)

* 616485bf9 Roll Skia from 299221eaa3a9 to 261f573f16db (1 revision) (flutter/engine#39535)

* e1e5289b6 Roll Skia from 261f573f16db to badcdf5635ab (1 revision) (flutter/engine#39538)

* f98e4f138 Ignore invalid filters when constructing an image compose filter (flutter/engine#39528)

* 14c8e6bde Roll Fuchsia Linux SDK from ibtVZPawJl1jwt5Sg... to 482Njb1v72P7fNyj4... (flutter/engine#39541)

* c9574d51a Roll Skia from badcdf5635ab to 54342413f5c0 (1 revision) (flutter/engine#39542)

* 4104eb5cb Revert "[macOS] Make FlutterEngine support multiple views (#37976)" (flutter/engine#39536)
itsjustkevin added a commit that referenced this pull request Feb 13, 2023
@itsjustkevin
Revert "Add Animated PNG demuxer (#31098)"
803b907 
This reverts commit b3e9642.
@itsjustkevin itsjustkevin mentioned this pull request Feb 13, 2023
Closed
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Feb 15, 2023
@cbracken
Improve CupertinoContextMenu to match native more (#117698)
a12e242 
* Change some values

* Change where/when the haptic feedback is happening. Now it's in comparison for me identical.

* Change the type of haptic feedback. Matches correctly now.

* Don't play haptic feedback when user aborts.

* Improve looks. Now it looks exactly alike

* - Move width to variable
- Add test for contextmenu

* Change background color of ContextMenuAction

* Change the colors in the test file

* Make Haptic Feedback optional

* Squashed commit of the following:

commit ce8efb439e7405a9c5e99d81252ba721229b8465
Author: engine-flutter-autoroll <[email protected]>
Date:   Mon Feb 13 07:29:25 2023 -0500

    ede2a0a3c Roll Skia from c6f1de2239fb to d85501fa487d (1 revision) (flutter/engine#39585) (#120593)

commit b33c76f017a1d23bd3e3a5bbaba24090a423cb5d
Author: engine-flutter-autoroll <[email protected]>
Date:   Mon Feb 13 06:27:23 2023 -0500

    1695b7bbc Bump github/codeql-action from 2.1.39 to 2.2.4 (flutter/engine#39584) (#120588)

commit b0c24e8d3d4f769ea5667fc1a751ce3bcecd4a4b
Author: xubaolin <[email protected]>
Date:   Mon Feb 13 18:11:28 2023 +0800

    fix a Slider theme update bug (#120432)

    * fix a Slider theme update bug

    * Code review feedback

commit 53fe8a3f942526cc711b78b4aa877bbcda8d2d7b
Author: engine-flutter-autoroll <[email protected]>
Date:   Mon Feb 13 02:37:24 2023 -0500

    4107a7b71 Roll Skia from 615965d545f4 to c6f1de2239fb (1 revision) (flutter/engine#39581) (#120580)

commit 3e659cf71f0037e7949efb4985c883f068528084
Author: engine-flutter-autoroll <[email protected]>
Date:   Mon Feb 13 00:01:18 2023 -0500

    1eef041d4 [Impeller] Source the pipeline color attachment pixel format from RenderPass textures (flutter/engine#39556) (#120576)

commit 238b0dbc04d66ec79f83cfd364ca185bb0c113ca
Author: engine-flutter-autoroll <[email protected]>
Date:   Sun Feb 12 23:09:24 2023 -0500

    Roll Flutter Engine from b7e80ad6ef51 to 1ff345ce5f63 (2 revisions) (#120574)

    * 5ad400e25 Roll Fuchsia Mac SDK from KpTOXssqVhPv2OBZi... to NZAnfCkpbswhYplty... (flutter/engine#39577)

    * 1ff345ce5 Roll Fuchsia Linux SDK from 8fdyKaKQqTPpjcp-L... to R6oclCbqlvHdyGgut... (flutter/engine#39578)

commit 527977b6af24c1663fd5864ef0dfea46a8fd4df3
Author: engine-flutter-autoroll <[email protected]>
Date:   Sun Feb 12 08:54:35 2023 -0500

    b7e80ad6e Roll Fuchsia Mac SDK from y35kWL0rP5Nd06lTg... to KpTOXssqVhPv2OBZi... (flutter/engine#39574) (#120559)

commit 6d68eb7b88e16f73c17c681c0c92fdfb58c5dd8d
Author: engine-flutter-autoroll <[email protected]>
Date:   Sun Feb 12 08:08:24 2023 -0500

    0aa4fcbd2 Roll Skia from ec87ec6fd34f to 615965d545f4 (1 revision) (flutter/engine#39573) (#120558)

commit 7295d4fe976cf76181b09f60ffc3b02a9f4587e9
Author: engine-flutter-autoroll <[email protected]>
Date:   Sun Feb 12 06:22:06 2023 -0500

    9a19d7eea Roll Fuchsia Linux SDK from arbaBzyUE2ok1bGl5... to 8fdyKaKQqTPpjcp-L... (flutter/engine#39572) (#120554)

commit d6ff0f2af93f48d2c8839130ad8bbe1a6cb2bb4b
Author: engine-flutter-autoroll <[email protected]>
Date:   Sun Feb 12 04:49:29 2023 -0500

    fe56a45b4 Roll Dart SDK from c4255cea566a to 1caf3a9ad101 (1 revision) (flutter/engine#39571) (#120552)

commit 274f6cb2d59746e75a03a9eace0a107139142f3f
Author: engine-flutter-autoroll <[email protected]>
Date:   Sat Feb 11 22:57:09 2023 -0500

    Roll Flutter Engine from 2cba062f9f4c to 05d81c0f2ebe (2 revisions) (#120547)

    * ae44d6f64 Roll Dart SDK from b1836aacc08a to c4255cea566a (1 revision) (flutter/engine#39568)

    * 05d81c0f2 Roll Skia from ac09a28afd34 to ec87ec6fd34f (1 revision) (flutter/engine#39569)

commit f04600bfb573bad7bc40a208ae84dfa4c320912a
Author: engine-flutter-autoroll <[email protected]>
Date:   Sat Feb 11 19:35:04 2023 -0500

    Roll Flutter Engine from d8e01097e66b to 2cba062f9f4c (2 revisions) (#120538)

    * 92e86a287 Roll Fuchsia Linux SDK from MVMTNxWJaWdwPWstz... to arbaBzyUE2ok1bGl5... (flutter/engine#39563)

    * 2cba062f9 Roll Fuchsia Mac SDK from FxFPRn_9rSWWAWFw0... to y35kWL0rP5Nd06lTg... (flutter/engine#39565)

commit 0db47bdd07afedaf62de17b88a815833a593e21f
Author: Casey Hillers <[email protected]>
Date:   Sat Feb 11 03:44:56 2023 -0800

    Revert "Fix BottomAppBar & BottomSheet M3 shadow (#119819)" (#120492)

    This reverts commit 0a97ef85c8706330c94abb57841680d19292fcc7.

commit 0346f4b18d8b239edaa12e08f7bce0efcbec727e
Author: engine-flutter-autoroll <[email protected]>
Date:   Sat Feb 11 06:43:37 2023 -0500

    d8e01097e Roll Fuchsia Mac SDK from 6nMZjuYXTcnD_VZQI... to FxFPRn_9rSWWAWFw0... (flutter/engine#39562) (#120519)

commit bbf8446d945f700990643fe89d259a0b30b6a01b
Author: engine-flutter-autoroll <[email protected]>
Date:   Sat Feb 11 04:54:59 2023 -0500

    761891200 Roll Dart SDK from 1d26a1d57edf to b1836aacc08a (1 revision) (flutter/engine#39561) (#120513)

commit d27de1de08cc7c59919cda7efee9e150469fcbec
Author: engine-flutter-autoroll <[email protected]>
Date:   Sat Feb 11 03:37:39 2023 -0500

    5efb42971 Roll Fuchsia Linux SDK from 482Njb1v72P7fNyj4... to MVMTNxWJaWdwPWstz... (flutter/engine#39559) (#120512)

commit 61e059f44f57fa529849f2a23e028b966d10cb5f
Author: engine-flutter-autoroll <[email protected]>
Date:   Sat Feb 11 01:36:39 2023 -0500

    Roll Flutter Engine from c3dc68e0e263 to 363355af5158 (2 revisions) (#120511)

    * 4c76e2de5 Roll Dart SDK from 02a5a3bedc5f to 1d26a1d57edf (2 revisions) (flutter/engine#39557)

    * 363355af5 Roll Skia from 6c3097e6f833 to ac09a28afd34 (1 revision) (flutter/engine#39558)

commit e42ab1cb0b1f1a08fd7211f03b4d59451ba3d3db
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Feb 10 23:47:09 2023 -0500

    c3dc68e0e Roll Skia from 70a3a194ec98 to 6c3097e6f833 (1 revision) (flutter/engine#39555) (#120508)

commit 859d57b3cf74b35a92836f70aa72ef28dfb9ef3f
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Feb 10 22:40:49 2023 -0500

    8baee2164 Roll Skia from 5230650dc096 to 70a3a194ec98 (2 revisions) (flutter/engine#39554) (#120507)

commit 4ab2ffd585dc8ca77b5933142263eac8fc5327be
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Feb 10 21:42:13 2023 -0500

    Roll Flutter Engine from f737dc868a3e to 3ac3338489d2 (2 revisions) (#120505)

    * b93428ef3 [Impeller] Adds wide gamut support for iOS. (flutter/engine#39111)

    * 3ac333848 Roll Skia from f0fc6aa4d797 to 5230650dc096 (4 revisions) (flutter/engine#39551)

commit b3613c4cf956d8576294e37dd021d0b327c6cd5e
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Feb 10 20:11:35 2023 -0500

    f737dc868 [macOS] Add XCode marks for TextInputPlugin (flutter/engine#39550) (#120501)

commit 941578ea955f5d094f7aec411daeb8761e30c87e
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Feb 10 19:12:03 2023 -0500

    Roll Flutter Engine from 6660300ea34f to 5e3ff1e5c9b3 (4 revisions) (#120495)

    * 1a3a8a098 Roll Fuchsia Mac SDK from 86sd_NCGPMuQh08NX... to 6nMZjuYXTcnD_VZQI... (flutter/engine#39546)

    * 3dbfc35d3 Roll Dart SDK from 63b8dc1906e5 to 02a5a3bedc5f (8 revisions) (flutter/engine#39547)

    * 0cea03bfe Roll Skia from 640fa258fc75 to f0fc6aa4d797 (1 revision) (flutter/engine#39548)

    * 5e3ff1e5c [Impeller] Don't use unnecessary stencil attachments (flutter/engine#39537)

commit d63c54c9c2d7e03663631a09d97777a3c7223e0b
Author: Flutter GitHub Bot <[email protected]>
Date:   Fri Feb 10 18:11:53 2023 -0500

    roll packages (#120493)

commit 2f9abd20f0b489a425862367ffe27c4833d93c9e
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Feb 10 17:22:32 2023 -0500

    Roll Flutter Engine from 4104eb5cbc40 to 6660300ea34f (6 revisions) (#120487)

    * 440e6bd6e [Impeller] Use minimal coverage for EntityPass clip restores (flutter/engine#39540)

    * 641d1d049 [web] Fixes invisible platform view compositing edge cases. (flutter/engine#39506)

    * 64414346f Revert "Remove deprecated TextInputClient scribble method code" (flutter/engine#39516)

    * e63404413 Roll Skia from 54342413f5c0 to 640fa258fc75 (3 revisions) (flutter/engine#39544)

    * 7bf8bfd02 add support to run dl_canvas_unittests on GPU surfaces (off by default) (flutter/engine#38993)

    * 6660300ea Use DisplayListMatrixClipTracker in DiffContext (flutter/engine#38010)

commit d5dbcb70855d35184f4f64cf4be66d76cc54207a
Author: Mouad Debbar <[email protected]>
Date:   Fri Feb 10 16:24:08 2023 -0500

    Revert "Revert "[web] Move JS content to its own `.js` files (#117691)" (#120275)" (#120363)

    This reverts commit 0fb4406c30d6427044fa8322a6278b92982cc22b.

commit 65fd924d848f611c36de6a1e1bf1059c334ac86f
Author: Casey Hillers <[email protected]>
Date:   Fri Feb 10 12:29:31 2023 -0800

    [conductor] Remove CiYaml model (#120458)

    * [conductor] Remove CiYaml model

    * Remove package:yaml

    * Update pubspec checksum

commit 52ab299362dc0d4ab87c45bba3dae4b77c020a98
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Feb 10 15:09:29 2023 -0500

    Roll Flutter Engine from add9e11edb66 to 4104eb5cbc40 (14 revisions) (#120470)

    * bf38bf6cf Bump to Chrome 111. (flutter/engine#39525)

    * d76023b53 Roll Skia from 128d82c8931d to 59c9ef67fa34 (3 revisions) (flutter/engine#39529)

    * da0e1463a Roll Skia from 59c9ef67fa34 to 4013995114e1 (2 revisions) (flutter/engine#39530)

    * 5203b6ff6 Roll Skia from 4013995114e1 to 182d5daf78dc (1 revision) (flutter/engine#39531)

    * b3e9642c6 Add Animated PNG demuxer (flutter/engine#31098)

    * 54665882c [Impeller] Generate a Metal library symbols file for shader debugging. (flutter/engine#39532)

    * 931bf7a47 Roll Skia from 182d5daf78dc to 299221eaa3a9 (1 revision) (flutter/engine#39533)

    * 3ad331a1a Roll Fuchsia Mac SDK from s0lx1q5xbqV1jkRZM... to 86sd_NCGPMuQh08NX... (flutter/engine#39534)

    * 616485bf9 Roll Skia from 299221eaa3a9 to 261f573f16db (1 revision) (flutter/engine#39535)

    * e1e5289b6 Roll Skia from 261f573f16db to badcdf5635ab (1 revision) (flutter/engine#39538)

    * f98e4f138 Ignore invalid filters when constructing an image compose filter (flutter/engine#39528)

    * 14c8e6bde Roll Fuchsia Linux SDK from ibtVZPawJl1jwt5Sg... to 482Njb1v72P7fNyj4... (flutter/engine#39541)

    * c9574d51a Roll Skia from badcdf5635ab to 54342413f5c0 (1 revision) (flutter/engine#39542)

    * 4104eb5cb Revert "[macOS] Make FlutterEngine support multiple views (#37976)" (flutter/engine#39536)

commit 780c9a8de15780094260232b3b8c97b2a9ef8088
Author: Kate Lovett <[email protected]>
Date:   Fri Feb 10 23:03:01 2023 +0300

    Remove deprecated SystemChrome.setEnabledSystemUIOverlays (#119576)

commit b2e37c65924d948f2389a933aed2cb730eb2423c
Author: Casey Hillers <[email protected]>
Date:   Fri Feb 10 11:01:04 2023 -0800

    [conductor] Tag engine versions (#120419)

    * [conductor] Tag engine versions

    * Move tag to repository

commit 25c2c22d2921c9e5407542960a043c8bca423b20
Author: Pascal Welsch <[email protected]>
Date:   Fri Feb 10 18:39:58 2023 +0100

    Delete Chrome temp cache after closing (#119062)

    * Delete Chrome temp cache after closeing

    * Update packages/flutter_tools/lib/src/web/chrome.dart

    Co-authored-by: Christopher Fujino <[email protected]>

    ---------

    Co-authored-by: Christopher Fujino <[email protected]>

commit 298c874eac79ef50f398decd211bae887d955a3e
Author: Michael Goderbauer <[email protected]>
Date:   Fri Feb 10 09:35:37 2023 -0800

    Fix classes that shouldn't be extended/instantiated/mixedin (#120409)

commit 858f94cfa5bdb266fe39241da405db8b2a2a7a21
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Feb 10 12:33:57 2023 -0500

    Roll Plugins from 73986f4cc857 to 02571ec0dd36 (3 revisions) (#120443)

    * 2daa07275 Update .cirrus.yml (flutter/plugins#7134)

    * b3c7582da [google_sign_in] Slight cleanup in GoogleSignInPlugin (flutter/plugins#7013)

    * 02571ec0d Manual roll Flutter from 2303f42250b1 to e3471f08d1d3 (24 revisions) (flutter/plugins#7147)

commit b0d04ea49325c3f191936f5e3bd5a4e21a4a4ce7
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Feb 10 12:32:45 2023 -0500

    add9e11ed Fix position of BackdropFilter above PlatformView (flutter/engine#39244) (#120415)

commit f05a555bcba43f14fe05f5d091b501d18536493f
Author: Pierre-Louis <[email protected]>
Date:   Fri Feb 10 18:32:43 2023 +0100

    Fix lerping for `NavigationRailThemeData` icon themes (#120066)

    * Fix lerping for NavigationRail icon themes

    * fix typo

commit 5dbd2810123ae85b2b1f30a5317178ba7685b3cb
Author: Renzo Olivares <[email protected]>
Date:   Fri Feb 10 09:31:07 2023 -0800

    Use String.codeUnitAt instead of String.codeUnits[] in ParagraphBoundary (#120234)

    * paragraph-boundary-opt

    * address comments

    * address comments

    ---------

    Co-authored-by: Renzo Olivares <[email protected]>

commit 96823590ec1eb2476e6a808e828a401e422673d8
Author: Xilai Zhang <[email protected]>
Date:   Fri Feb 10 09:29:09 2023 -0800

    post submit only (#120411)

commit 001c4951b61957f94d66fe1600efe6e0aa40248b
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Feb 9 20:14:10 2023 -0500

    Roll Flutter Engine from 9a40a384997d to e1d0032029e4 (6 revisions) (#120414)

    * 081b9fc2d [Windows] Prepare keyboard & text input plugins for multi-view (flutter/engine#39464)

    * b9073d13e [macOS] Make FlutterEngine support multiple views (flutter/engine#37976)

    * 028deae48 [ios] Convert `int` in Dart to `long long` in Objective-C. (flutter/engine#39331)

    * 8f52c598b Roll Skia from e238cde8581d to 128d82c8931d (5 revisions) (flutter/engine#39524)

    * c3c7b2478 Fix classes that shouldn't be extended/instantiated/mixedin (flutter/engine#39517)

    * e1d003202 Roll Fuchsia Linux SDK from cn89DIQTewbdhBTO-... to ibtVZPawJl1jwt5Sg... (flutter/engine#39526)

commit e3471f08d1d3f816fff8afd1ce9385dd3feb73d2
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Feb 9 18:50:11 2023 -0500

    Roll Flutter Engine from 40e17fb5244c to 9a40a384997d (3 revisions) (#120403)

    * fd110e068 Reland "[macos] Move TextInputPlugin outside of visible area" (flutter/engine#39194)

    * e50569ba5 Remove unused .ci.yaml properties (flutter/engine#39501)

    * 9a40a3849 [Impeller] Support blit passes on Vulkan. (flutter/engine#39438)

commit f945ad99c3f60408fc5d4690ed67412fc0f7aff1
Author: Ivan Dlugos <[email protected]>
Date:   Fri Feb 10 00:05:44 2023 +0100

    Resolve dwarf paths to enable source-code mapping of stacktraces (#114767)

    * feat: add "--resolve-dwarf-paths" to gen_snapshot

    * chore: update tests

commit fecd5c969ef8f2bdac27195304e8d2031ccda82f
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Feb 9 18:03:39 2023 -0500

    Roll Flutter Engine from 39c41c40a4bc to 40e17fb5244c (3 revisions) (#120397)

    * 24bde68a4 Roll Fuchsia Mac SDK from 4cSuz7lZeOIfzhUHg... to s0lx1q5xbqV1jkRZM... (flutter/engine#39520)

    * de841f63d Enable UIA in Window (flutter/engine#39513)

    * 40e17fb52 Roll Skia from db81bd26f149 to e238cde8581d (1 revision) (flutter/engine#39522)

commit 425ab5dca5aa99d8027a2afbffd98875fa5762bb
Author: Jonah Williams <[email protected]>
Date:   Thu Feb 9 12:58:57 2023 -0800

    Remove test that verifies we can switch to stateless (#120390)

commit 2239f6c8a91dff3495238f0496ea86d882a3b122
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Feb 9 15:47:09 2023 -0500

    Roll Flutter Engine from 603fd71f4749 to 39c41c40a4bc (3 revisions) (#120393)

    * 8ae722400 Only run malioc analysis for a couple of GPU types (flutter/engine#39515)

    * 326f4fcf1 Roll Skia from 1544d3a123bc to db81bd26f149 (2 revisions) (flutter/engine#39519)

    * 39c41c40a Manual roll ICU from 2cce76fd67af to 266a46937f05 (1 revision) (flutter/engine#39518)

commit 1faa95009e947c66e8139903e11b1866365f282c
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Feb 9 14:20:21 2023 -0500

    Roll Flutter Engine from eb346ba63f69 to 603fd71f4749 (2 revisions) (#120381)

    * 3483e33b3 Roll buildroot to 0180f883 (flutter/engine#39503)

    * 603fd71f4 Roll Skia from 970c33b0f43e to 1544d3a123bc (2 revisions) (flutter/engine#39514)

commit 91dc513a395f51e84b237617a7573336cf61c20b
Author: Qun Cheng <[email protected]>
Date:   Thu Feb 9 10:41:09 2023 -0800

    Add missing parameters to `CheckboxListTile` (#120118)

    * Add missing parameters to CheckboxListTile

    * Update test message and api doc

    * Reorder parameters

    ---------

    Co-authored-by: Qun Cheng <[email protected]>

commit c8c8621416065480c82180f85864efb467bb123f
Author: Michael Thomsen <[email protected]>
Date:   Thu Feb 9 19:40:32 2023 +0100

    Clean up null safety messages (#120350)

commit 3fdd6ee46fc2cc99ad69bf888fc7cf1311be3a66
Author: chunhtai <[email protected]>
Date:   Thu Feb 9 10:38:47 2023 -0800

    Reland "Overlay always applies clip (#113770)" (#116674)

    * Reland "Overlay always applies clip (#113770)"

    This reverts commit d0afbd72a782eb20657f01b082ef29a2517eee54.

    * Root navigator will not clip

commit 1546fa08d3243f3d9401dfa0620231e7cb72ff67
Author: Christopher Fujino <[email protected]>
Date:   Thu Feb 9 10:34:02 2023 -0800

    [flutter_tools] toolExit on sdkmanager exit during doctor --android-licenses (#120330)

    * tool exit on sdk manager exit and add test

    * be more specific about error message

commit 42b20cf953b9095f0a9bad543f8196fd421a2417
Author: Hans Muller <[email protected]>
Date:   Thu Feb 9 10:34:01 2023 -0800

    Added ListTile.titleAlignment, ListTileThemeData.titleAlignment (#119872)

    * added ListTile.textAlignment

    * changed titlesHeight to titleHeight

    * fixed a typo

    * Add tests and example

    * Update tests

    * update example test

    ---------

    Co-authored-by: tahatesser <[email protected]>

commit 0521c60cd2b03c3a2ad22e986f0dc5779078e939
Author: Daco Harkes <[email protected]>
Date:   Thu Feb 9 19:32:52 2023 +0100

    Support --local-engine=ios_debug_sim (#119524)

    Fixes:

    * https://github.com/flutter/flutter/issues/119523

commit 5e506aeb61edf5bc96071f500bf92b4c6710156c
Author: Qun Cheng <[email protected]>
Date:   Thu Feb 9 10:32:49 2023 -0800

    Add missing parameters to `SwitchListTile` (#120115)

    * Add missing parameters to SwitchListTile

    * Update SwitchListTile doc

    * Update doc for existing APIs

    * Address comment

    * Fix typo

    ---------

    Co-authored-by: Qun Cheng <[email protected]>

commit 9996126740de8e8f6319fc9b803405a4f7e83e78
Author: Eilidh Southren <[email protected]>
Date:   Thu Feb 9 16:51:26 2023 +0000

    Add proper disabled values for input chips (#120192)

    * add proper disabled values for input chips

    * added test

commit cd3806337cc62739fa20d8b85b2fa65ac5eefc6f
Author: Daco Harkes <[email protected]>
Date:   Thu Feb 9 17:37:09 2023 +0100

    Update gallery.dart (#120366)

    Incorporating:

    * https://github.com/flutter/flutter/issues/120260

commit 468e21c50b848826862bd2511f1dba0518f4828b
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Feb 9 11:17:08 2023 -0500

    Manual roll Flutter Engine from 2f2e2e27cb28 to eb346ba63f69 (7 revisions) (#120364)

    * 58abb04e0 increase first frame timeout (flutter/engine#39504)

    * e5d61519f Update shader_optimization.md (flutter/engine#39497)

    * b0816a4bc Roll Skia from 638bfdc9e23c to 1762c093d086 (8 revisions) (flutter/engine#39507)

    * 31ec7f29c Roll Skia from 1762c093d086 to 5899b39484db (1 revision) (flutter/engine#39508)

    * 35934fd54 Roll Fuchsia Mac SDK from vV4hr9qgSXTVhRzEr... to 4cSuz7lZeOIfzhUHg... (flutter/engine#39509)

    * 0cfdd8a22 Roll Skia from 5899b39484db to 970c33b0f43e (1 revision) (flutter/engine#39510)

    * eb346ba63 Roll Fuchsia Linux SDK from B6PQF-BmeXvmNZJy5... to cn89DIQTewbdhBTO-... (flutter/engine#39511)

commit 0e7c5a885ebfb8017222a6eba7192efa8c200a90
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Feb 9 11:11:18 2023 -0500

    Roll Plugins from f59c08db3f27 to 73986f4cc857 (5 revisions) (#120362)

    * 84ad624e3 Manual roll Flutter from e8eac0d047cd to 2303f42250b1 (23 revisions) (flutter/plugins#7132)

    * d8812bc75 [ci] Complete architecture switch for iOS (flutter/plugins#7066)

    * 703111040 [google_maps_flutter_android] Fixes points losing precision when converting to LatLng (flutter/plugins#7101)

    * 435c46f21 [camera] availableCameras() implementation for CameraX re-write (flutter/plugins#6945)

    * 73986f4cc [image_picker_android] Name picked files to match the original filenames where possible  (flutter/plugins#6096)

commit dee226ef8a463e87edeed4115a27fb2743424e27
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Feb 9 01:51:04 2023 -0500

    Manual roll Flutter Engine from 89c8a1393d4b to 2f2e2e27cb28 (3 revisions) (#120333)

    * 24fcdc5d2 [Impeller] Fix sampling management problems (flutter/engine#39483)

    * 4270d7445 Revert "Revert "[ios_platform_view] MaskView pool to reuse maskViews. (#38989)" (#39490)" (flutter/engine#39498)

    * 2f2e2e27c Manual roll Dart SDK from 9c68f2a74491 to 63b8dc1906e5 (3 revisions) (flutter/engine#39502)

commit b1c4d5686e79ea8f32ad67469e663fb9d0d2a0ca
Author: Christopher Fujino <[email protected]>
Date:   Wed Feb 8 16:55:05 2023 -0800

    Fix widget inspector null check (#120143)

    * add failing test

    * fix

    * remove extra whitespace

    * fix test failure

    * disable trackrebuilddirtywidgets in teardown

    * remove no-shuffle annotation

    * fix

commit 0fb4406c30d6427044fa8322a6278b92982cc22b
Author: Kevin Chisholm <[email protected]>
Date:   Wed Feb 8 18:17:29 2023 -0600

    Revert "[web] Move JS content to its own `.js` files (#117691)" (#120275)

    This reverts commit e03029ef6a0c2040476bf6602da4e5d1271eb77d.

commit ef854a3db076acaa42996110804d24c582c1c633
Author: Loïc Sharma <[email protected]>
Date:   Wed Feb 8 15:24:42 2023 -0800

    [Tool] [Windows] Output build duration (#120311)

    * [Tool][Windows] Output build duration

    * Tweak

    * Format

commit b4908f376e7ed77a30905a0a7c0c6b49a3486703
Author: Drew Roen <[email protected]>
Date:   Wed Feb 8 16:29:30 2023 -0600

    Update .cirrus.yml (#120315)

commit 4ddf0a89eb939f04ab63f074927d43a405426a3d
Author: engine-flutter-autoroll <[email protected]>
Date:   Wed Feb 8 17:06:12 2023 -0500

    Manual roll Flutter Engine from cc4ca6a06ab3 to 89c8a1393d4b (6 revisions) (#120319)

    * ef9d3e9ad Roll Skia from d52b1a24c407 to 99a797d497fe (1 revision) (flutter/engine#39489)

    * 6a2de773e Revert "[ios_platform_view] MaskView pool to reuse maskViews. (#38989)" (flutter/engine#39490)

    * 62b49804f Disable mouse-input-test (flutter/engine#39492)

    * 28c3c8139 Roll Skia from 99a797d497fe to 638bfdc9e23c (4 revisions) (flutter/engine#39494)

    * 0d5653352 Roll Fuchsia Linux SDK from HGN3rmf37VA5Sc0e1... to B6PQF-BmeXvmNZJy5... (flutter/engine#39493)

    * 89c8a1393 Migrate iOS and Android to use pushRouteInformation (flutter/engine#39372)

commit 4a9660881e3092d64de2d64a0272d4d801863941
Author: Andrew Kolos <[email protected]>
Date:   Wed Feb 8 21:41:19 2023 +0000

    Reland "Stop recursively including assets from asset directories" (#120312)

    * stop recursively including assets from asset directories

    * remove unused imports

    * lint

commit 2303f42250b11cd4e553660d89483ead57bc14d1
Author: engine-flutter-autoroll <[email protected]>
Date:   Wed Feb 8 14:24:12 2023 -0500

    Manual roll Flutter Engine from bdc5b6b768f6 to cc4ca6a06ab3 (8 revisions) (#120309)

    * 6c9f0c00d [macOS] Support text input autocomplete (flutter/engine#39460)

    * 08f50504d Roll Skia from f30529658275 to 7cac214d0f4b (1 revision) (flutter/engine#39478)

    * 9aa088df0 Roll Fuchsia Linux SDK from aRqjqB76Z2gNQsrTA... to HGN3rmf37VA5Sc0e1... (flutter/engine#39480)

    * 24fd06e79 [Impeller] Fix stroke cap drawing not correct. (flutter/engine#39481)

    * c0b1b2ccf Roll Fuchsia Mac SDK from uYw6cCpJIpQa42G4O... to vV4hr9qgSXTVhRzEr... (flutter/engine#39485)

    * 586378ff1 Roll Skia from 7cac214d0f4b to 4d064e82ce8e (1 revision) (flutter/engine#39486)

    * 81f6c3393 Roll Skia from 4d064e82ce8e to d52b1a24c407 (4 revisions) (flutter/engine#39487)

    * cc4ca6a06 Manual roll Dart SDK from a507a9057730 to 9c68f2a74491 (11 revisions) (flutter/engine#39488)

commit 212bac80d15c18e686ca8526e9e5b425622dd1a5
Author: Hans Muller <[email protected]>
Date:   Wed Feb 8 10:53:55 2023 -0800

    Revert "Update `ExpansionTile` to support Material 3 & add an example (#119712)" (#120300)

    This reverts commit e8eac0d047cd44feabf0a62ab06bcecbbcf24b1b.

commit 51227a9a50701ce7a9293c38da35b8a70eaf6e8d
Author: Qun Cheng <[email protected]>
Date:   Wed Feb 8 10:53:24 2023 -0800

    Add missing parameters to `RadioListTile` (#120117)

commit 3a514175d3a301d7dde2e18e773907c8b0a108d1
Author: Camille Simon <[email protected]>
Date:   Wed Feb 8 10:51:52 2023 -0800

    Remove Android spell check integration test (#120144)

commit ec289f1eb41b525033bd5701a53a5c32d449059a
Author: Gabriel Terwesten <[email protected]>
Date:   Wed Feb 8 19:51:50 2023 +0100

    Don't call `PlatformViewCreatedCallback`s after `AndroidViewController` is disposed (#116854)

    * Don't call `PlatformViewCreatedCallback`s after `AndroidViewController` is disposed

    Before this change it was possible that, if a `AndroidViewController` was disposed before we got the notification that the platform view was created, `PlatformViewCreatedCallback`s where called even after calling `AndroidViewController.dispose`.

    Also makes `_PlatformViewLinkState._onPlatformViewCreated` more carful to only call `setState` when mounted.

    Closes #84628
    Closes #96384

    * Allow all widgets to remove listeners from controller

    * Remove assert

    * Add expectations to test

commit bfea22db5c7e6e2f27ec7f5cea5545377565af3b
Author: engine-flutter-autoroll <[email protected]>
Date:   Wed Feb 8 13:05:54 2023 -0500

    Roll Plugins from 6f985d57b04b to f59c08db3f27 (3 revisions) (#120303)

    * 40c2e1169 [local_auth_android] update java complie sdk version to green tree (flutter/plugins#7121)

    * 81c6fd07a Update release tooling to give a workaround for predictable failing case https://github.com/flutter/flutter/issues/120116 (flutter/plugins#7111)

    * f59c08db3 Roll Flutter from 3c3c9a1bd98f to e8eac0d047cd (21 revisions) (flutter/plugins#7122)

commit 0a97ef85c8706330c94abb57841680d19292fcc7
Author: Eilidh Southren <[email protected]>
Date:   Wed Feb 8 18:04:21 2023 +0000

    Fix BottomAppBar & BottomSheet M3 shadow (#119819)

    * remove m3 shadows

    * fix

    * fix that test over there

commit 0588b925a070a591da8e199cb17d83b74daa9de1
Author: MarchMore <[email protected]>
Date:   Wed Feb 8 19:01:11 2023 +0100

    Removed "if" on resolving text color at "SnackBarAction" (#120050)

    * Removed "if" on resolving text color at "SnackBarAction"

    Removed multiple "if" for "resolveForegroundColor" method at "SnackBarAction". At least one of the multiple "if" ("defaults.actionTextColor is MaterialStateColor") led to not applying a custom set color (e.g. MaterialColor "Colors.red") for the action text when using Material 3.

    The second "if" ("snackBarTheme.actionTextColor is MaterialStateColor") also makes no sense then as the set color of the Theme would lead to the same blocking behaviour of manual color assignment.

    The last remaining "if" ("widget.textColor is MaterialStateColor") will be unnecessary if the other "if" will be removed, as it will be resolved in the code right afterwards.

    The three "if" also seems to block the usage of the custom text color or the color at all if the widget is in the "MaterialState.disabled" state.

    * Adjusted recent modifications to SnackBarAction's text color resolution

    * Now the "widget.textColor" is checked if it is set.
      * If it is a MaterialStateColor, it will be used
      * Otherwise continue with normal resolution (It will be used in the resolution anyways because it's set)

    * Repeat same steps with "snackBarTheme.actionTextColor" if previous was not set

    * Repeat same steps with "defaults.actionTextColor" if previous was not set

    * Reverted the auto formatting changes

    * Added two test cases to "snack_bar_test"

     * Test for setting a MaterialColor to a SnackBarAction' label (M3)
     * Test for setting a MaterialStateColor to a SnackBarAction' label (M3)

    * Renamed test cases "Snackbar labels can be colored"

commit 75ca31b0e48d15c97c4cddf68b25bfa0bd3d70f3
Author: Hans Muller <[email protected]>
Date:   Wed Feb 8 08:52:41 2023 -0800

    Correct Badge interpretation of its alignment parameter (#119853)

commit d8154fde7a995f898abf263998692f509c49b382
Author: engine-flutter-autoroll <[email protected]>
Date:   Wed Feb 8 11:00:29 2023 -0500

    Manual roll Flutter Engine from f310ffd1461a to bdc5b6b768f6 (12 revisions) (#120261)

    * 0e25c0a1c [impeller] ensure full glyphs respect alpha (flutter/engine#39377)

    * 684cfe292 Add helpers for updating arm tools in CIPD (flutter/engine#39458)

    * e6cf1c532 Roll Skia from 87dbc81b421f to bd48f82dcabb (8 revisions) (flutter/engine#39459)

    * bf8547dd9 Override _accessibilityHitTest to fix IOS 16 semantics issues  (flutter/engine#38794)

    * 2e225eb6b Manual roll Dart SDK from a507a9057730 to 5c74c8b64dec (9 revisions) (flutter/engine#39462)

    * ca05af79e [Windows] Remove accessibility root assumptions (flutter/engine#39441)

    * 3e9eb95ea Roll Skia from bd48f82dcabb to f30529658275 (7 revisions) (flutter/engine#39463)

    * 85958c2ea Update malioc analysis golden file (flutter/engine#39461)

    * 7098858dc Roll Fuchsia Mac SDK from zYEsaCaA1cokDUU43... to uYw6cCpJIpQa42G4O... (flutter/engine#39466)

    * bc8d3fca7 Revert "Manual roll Dart SDK from a507a9057730 to 5c74c8b64dec (9 revisions) (#39462)" (flutter/engine#39470)

    * 28837b3ad Revert "Revert "Manual roll Dart SDK from a507a9057730 to 5c74c8b64dec (9 revisions) (#39462)" (#39470)" (flutter/engine#39475)

    * bdc5b6b76 Revert "Revert "Revert "Manual roll Dart SDK from a507a9057730 to 5c74c8b64dec (9 revisions) (#39462)" (#39470)" (#39475)" (flutter/engine#39477)

commit 7f578fb01f1cc71f969bfd76e25bebc4d8eea19b
Author: Mouad Debbar <[email protected]>
Date:   Wed Feb 8 10:42:02 2023 -0500

    Revert "Stop recursively including assets from asset folders (#120167)" (#120283)

    This reverts commit da36bd6fc02603ca446093a27f86e73dea768e82.

commit 3f98c0f8f98bf3ddae4233316c6a57a6571e9cb1
Author: Qun Cheng <[email protected]>
Date:   Tue Feb 7 23:55:24 2023 -0800

    Add trackOutlineColor for Switch and SwitchListTile (#120140)

    * Add trackOutlineColor for Switch and SwitchListTile

    * Update tests

    * Update test

    * Clean up unnecessary StatefulBUilder in tests

    * Fix failed test

    ---------

    Co-authored-by: Qun Cheng <[email protected]>

commit 6e7f58037003028136c971728776bc63d3d53df1
Author: xubaolin <[email protected]>
Date:   Wed Feb 8 12:37:24 2023 +0800

    fix a TextFormField bug (#120182)

    * fix a TextFormField bug

    * review feedback

commit 1e6e6d41e3f747640119cee8e58914547ec44377
Author: Zachary Anderson <[email protected]>
Date:   Tue Feb 7 20:18:32 2023 -0800

    Revert "Roll Flutter Engine from f310ffd1461a to 7098858dc0a5 (9 revisions) (#120251)" (#120257)

    This reverts commit f94fa7ea2d45311a75bc3ec4d5b3d87960c7b2cd.

commit 99b6bd8c05a56680a62b161698c069d39951caf2
Author: Renzo Olivares <[email protected]>
Date:   Tue Feb 7 18:55:26 2023 -0800

    Add support for extending selection to paragraph on ctrl + shift + arrow up/down on Non-Apple platforms (#120151)

    * Add support for extending selection to paragraph on ctrl + shift + arrow up/down for common keyboard actions

    * Add ctrl + shift + arrow up/down common text editing shortcuts/actions

    * fix analyzer

    ---------

    Co-authored-by: Renzo Olivares <[email protected]>

commit f94fa7ea2d45311a75bc3ec4d5b3d87960c7b2cd
Author: engine-flutter-autoroll <[email protected]>
Date:   Tue Feb 7 21:38:11 2023 -0500

    Roll Flutter Engine from f310ffd1461a to 7098858dc0a5 (9 revisions) (#120251)

    * 0e25c0a1c [impeller] ensure full glyphs respect alpha (flutter/engine#39377)

    * 684cfe292 Add helpers for updating arm tools in CIPD (flutter/engine#39458)

    * e6cf1c532 Roll Skia from 87dbc81b421f to bd48f82dcabb (8 revisions) (flutter/engine#39459)

    * bf8547dd9 Override _accessibilityHitTest to fix IOS 16 semantics issues  (flutter/engine#38794)

    * 2e225eb6b Manual roll Dart SDK from a507a9057730 to 5c74c8b64dec (9 revisions) (flutter/engine#39462)

    * ca05af79e [Windows] Remove accessibility root assumptions (flutter/engine#39441)

    * 3e9eb95ea Roll Skia from bd48f82dcabb to f30529658275 (7 revisions) (flutter/engine#39463)

    * 85958c2ea Update malioc analysis golden file (flutter/engine#39461)

    * 7098858dc Roll Fuchsia Mac SDK from zYEsaCaA1cokDUU43... to uYw6cCpJIpQa42G4O... (flutter/engine#39466)

commit cd125e1f71209b425cc4fdf36b62fcef771ff743
Author: Greg Price <[email protected]>
Date:   Tue Feb 7 17:17:23 2023 -0800

    Add test for RenderProxyBoxMixin; clarify doc, resolve TODO (#117664)

    * Add test for RenderProxyBoxMixin; clarify doc, resolve TODO

    The TODO comment suggested this mixin would no longer be needed once
    a Dart issue on inherited constructors was fixed:
      https://github.com/dart-lang/sdk/issues/31543
    That issue is now long since fixed, so I went to go carry out the TODO.

    But in doing so, I realized that the mixin's documentation was more
    right than the TODO comment: even with that issue fixed, there is a
    legitimate use case for this mixin, namely to reuse the implementation
    of RenderProxyBox in a class that also inherits from some other base
    class.  Moreover, searching GitHub I found an example of a library
    that makes real use of that capability.

    So I think the right resolution is to accept that this separation
    is useful and delete the TODO.

    Then, add a test with an extremely simplified sketch of that
    real-world example.  In case someone in the future attempts to
    simplify this mixin away, the test will point us at the use case
    that would be broken by such a change.

    Also remove the only in-tree use of the mixin, which was redundant;
    and expand the mixin's documentation to advise about that case.

    * Tweak formatting

    Co-authored-by: Michael Goderbauer <[email protected]>

    * Cut comments

    ---------

    Co-authored-by: Michael Goderbauer <[email protected]>

commit 98b3e48ed4e722acb0c4bb897397fc817057b5f6
Author: Greg Price <[email protected]>
Date:   Tue Feb 7 16:04:23 2023 -0800

    Fix hang on successful dev/bots/analyze.dart (#117660)

    Fixes #117659

    It turns out this was due to the output-suppression timer introduced
    recently as part of cleaning up the output (#109206); on success, the
    script would wait 10 minutes for the timeout to expire.  This didn't
    affect CI because this feature doesn't apply in CI (as detected by
    lack of color on stdout.)

    Fix the issue by cleaning up the timer on success in the same way
    as on failure.

    While here, clean up the final summary messages slightly,
    and also cut the trailing space that printProgress was leaving
    on each line.

commit aed9b4adce2f8301469b242e74a9e9dea8a9da66
Author: Christopher Fujino <[email protected]>
Date:   Tue Feb 7 13:42:20 2023 -0800

    Revert "Revert "Fix unable to find bundled Java version (#119244)" (#119981)" (#120107)

    This reverts commit f7c2bd05f0167f9d9c8cc4e96f10dfc7a6a7c848.

commit 5be7f6639c0eb2b90e5c819a041cb15142ea27ce
Author: engine-flutter-autoroll <[email protected]>
Date:   Tue Feb 7 15:28:28 2023 -0500

    f310ffd14 Roll Skia from 3b1401c4870d to 87dbc81b421f (4 revisions) (flutter/engine#39457) (#120214)

commit 1089588863835a0b4a9ab0cdbc4afff451a3b7b6
Author: Christopher Fujino <[email protected]>
Date:   Tue Feb 7 12:10:18 2023 -0800

    un-pin package:intl (#119900)

commit 0b0450fbffcc7c7dbe0794dd3a79c6368f5613c9
Author: Justin McCandless <[email protected]>
Date:   Tue Feb 7 11:52:51 2023 -0800

    Web tab selection (#119583)

    Correct selection behavior when tabbing into a field on the web.

commit 1c225675c5d61e7ceba9c7c9762fdb59e2c41f2d
Author: Qun Cheng <[email protected]>
Date:   Tue Feb 7 11:16:24 2023 -0800

    Update to v0.158 of the token database. (#120149)

    * Update to v0.158 of the token database.

    * Update checkbox template

    * Fix DatePickerTheme test

    ---------

    Co-authored-by: Qun Cheng <[email protected]>

commit e8eac0d047cd44feabf0a62ab06bcecbbcf24b1b
Author: Taha Tesser <[email protected]>
Date:   Tue Feb 7 18:21:18 2023 +0200

    Update `ExpansionTile` to support Material 3 & add an example (#119712)

commit da36bd6fc02603ca446093a27f86e73dea768e82
Author: Andrew Kolos <[email protected]>
Date:   Tue Feb 7 11:20:23 2023 -0500

    Stop recursively including assets from asset folders (#120167)

    * add test

    * fix

    * use preexisting testFileSystem

    * fix variant tests

    * Revert "use preexisting testFileSystem"

    This reverts commit b6df288ef4a6ff007ecd984e98a1a3f2001ad242.

    * nit: grammar

commit f2e89755e54f0e7562503003915afd2799330861
Author: engine-flutter-autoroll <[email protected]>
Date:   Tue Feb 7 11:10:08 2023 -0500

    b67690f69 Roll Skia from 6babb6a1afe6 to 3b1401c4870d (1 revision) (flutter/engine#39455) (#120198)

commit e03029ef6a0c2040476bf6602da4e5d1271eb77d
Author: Mouad Debbar <[email protected]>
Date:   Tue Feb 7 10:51:52 2023 -0500

    [web] Move JS content to its own `.js` files (#117691)

commit 3f5b105fc790403df71c1b6bf46dd8b05943f2bd
Author: engine-flutter-autoroll <[email protected]>
Date:   Tue Feb 7 10:51:26 2023 -0500

    Roll Plugins from d065e4e0a82a to 6f985d57b04b (10 revisions) (#120193)

    * 883864599 [image_picker] GIF files will animate without permissions. PNG and GIF files will retain their image type if missing permissions. (flutter/plugins#7084)

    * 7a63dbc8f [camera] flip/change camera while recording - platform interface (flutter/plugins#7011)

    * c6be93605 Roll Flutter from b8f5394a5ca6 to 3c3c9a1bd98f (3 revisions) (flutter/plugins#7107)

    * eb0a6b562 [gh_actions]: Bump github/codeql-action from 2.1.37 to 2.2.1 (flutter/plugins#7059)

    * dc0d3a02b [camerax] Wrap methods necessary for preview implementation (flutter/plugins#7046)

    * c9f6bee71 [local_auth]: Bump core from 1.8.0 to 1.9.0 in /packages/local_auth/local_auth_android/android (flutter/plugins#6393)

    * f5957bde8 [webview_flutter_web] Avoids XHR when possible. (flutter/plugins#7090)

    * 55f257382 [Espresso] Update expressio dependencies  (flutter/plugins#7108)

    * 76ea8c8ce [url_launcher_ios] Update minimum Flutter version to 3.3 and iOS 11 (flutter/plugins#7110)

    * 6f985d57b Redistribute ownership of cross-platform plugin components (flutter/plugins#7093)

commit d7f742e90e1b884be248ee6277d0a1112c333238
Author: engine-flutter-autoroll <[email protected]>
Date:   Tue Feb 7 10:22:29 2023 -0500

    Roll Flutter Engine from 5aadda2f40b1 to e432b82f49f3 (3 revisions) (#120191)

    * ca47bbc7e Roll Skia from 83da27e4cd3a to 6babb6a1afe6 (1 revision) (flutter/engine#39451)

    * cabdc9e23 Roll Fuchsia Mac SDK from jD_N9MDLvRtOuBMgY... to zYEsaCaA1cokDUU43... (flutter/engine#39453)

    * e432b82f4 Roll Fuchsia Linux SDK from wlbzrDXNCXQZV0QdG... to aRqjqB76Z2gNQsrTA... (flutter/engine#39454)

commit a6ea64457a4457f54ee8669afdeb9de01b2963e6
Author: Konstantin Sokolovskyi <[email protected]>
Date:   Tue Feb 7 14:45:50 2023 +0100

    Fix cut button creation in 'buttonItemsForToolbarOptions' (#119822)

    * Fix cut button creation in buttonItemsForToolbarOptions

    * Remove extra spaces in tests

    * Replace fails with expects, Add periods in the comments

commit 16441f4bf77012b36d49a97e57069147432012f5
Author: engine-flutter-autoroll <[email protected]>
Date:   Tue Feb 7 06:00:32 2023 -0500

    5aadda2f4 Roll Skia from 419bb63e733d to 83da27e4cd3a (1 revision) (flutter/engine#39448) (#120172)

commit 7a6f1d81d68c24656e64ce1b3e27461156461144
Author: Eilidh Southren <[email protected]>
Date:   Tue Feb 7 10:53:36 2023 +0000

    M3 segmented buttons token fixes (#120095)

    * add icon button property override

    * Revert "add icon button property override"

    This reverts commit 6c7f4d30671f417d0f4a311bdb186bd4ebc456c8.

    * segmented button updates

    * button changes

    * fix

    * put that thing back where it came from

    * template updates

    * analyzer fixes

    * rename parameter

    * analyzer fixes

    * string interpolation fix

    * template updates

    * test updates

commit a808ba0545cc305aef37b687be9ca6bbdf6de4a3
Author: engine-flutter-autoroll <[email protected]>
Date:   Tue Feb 7 02:22:27 2023 -0500

    39f5e4cba Roll Skia from 7e2c9f54c0fd to 419bb63e733d (1 revision) (flutter/engine#39447) (#120159)

commit 1d0cbbb244ddf840285083957bb40866e3cc5b6c
Author: xubaolin <[email protected]>
Date:   Tue Feb 7 14:10:06 2023 +0800

    fix a [SelectableRegion] crash bug (#120076)

    * fix a crash bug

    * review feedback

commit cf3fc01774893df9019366b601e5d0621ec27873
Author: Renzo Olivares <[email protected]>
Date:   Mon Feb 6 21:40:18 2023 -0800

    remove deprecated accentTextTheme and accentIconTheme from ThemeData (#119360)

    Co-authored-by: Renzo Olivares <[email protected]>

commit 845f7bb42a9e77f2192595abcccc9742428893c1
Author: engine-flutter-autoroll <[email protected]>
Date:   Mon Feb 6 22:10:30 2023 -0500

    Roll Flutter Engine from 2a104cdfcdf8 to 165126e7034c (13 revisions) (#120150)

    * ec45e72a2 Roll Dart SDK from a507a9057730 to f18aa4402c1a (3 revisions) (flutter/engine#39395)

    * 1f0cb90da Roll Skia from 45a4fdcc0cb0 to 1bc762cbb8ce (1 revision) (flutter/engine#39397)

    * b19b263de Roll Fuchsia Mac SDK from j6dhXDhI_KUUyqTSF... to f7zsdfKoUWP6RD8S_... (flutter/engine#39398)

    * a6cc2517b Roll Fuchsia Linux SDK from Z6Bdg2fbH4n5ptsKZ... to V9ahWWCSVIMrpc9LX... (flutter/engine#39399)

    * af02efb3f Revert "Roll Dart SDK from a507a9057730 to f18aa4402c1a (3 revisions) (#39395)" (flutter/engine#39422)

    * aa0ff2173 Migrate engine_v2_builds to python3. (flutter/engine#39404)

    * a87b7455a Use jdk 11 in the engine. (flutter/engine#39375)

    * 75722215e Fix cpp-wrappers archive. (flutter/engine#39400)

    * 696049ef1 Roll Fuchsia Mac SDK from f7zsdfKoUWP6RD8S_... to jD_N9MDLvRtOuBMgY... (flutter/engine#39439)

    * 0c61605a7 Roll Fuchsia Linux SDK from V9ahWWCSVIMrpc9LX... to wlbzrDXNCXQZV0QdG... (flutter/engine#39435)

    * 6024bef6b Roll Skia from 1bc762cbb8ce to 7e2c9f54c0fd (23 revisions) (flutter/engine#39440)

    * 0315d0601 [Windows] Fix the 'engine restart resets keyboard' test (flutter/engine#39380)

    * 165126e70 iOS keyboard animation synchronization (flutter/engine#37604)

commit 71971f22325face326087b7b35d4ddc5f9662ab9
Author: Jenn Magder <[email protected]>
Date:   Mon Feb 6 18:56:38 2023 -0800

    Run `verify_binaries_codesigned` task on release branches (#120141)

    * Run verify_binaries_codesigned on release branches

    * Revert branches

commit e62abfae62763d9e69c1ef4615c8e3fdd02f8456
Author: Sam Rawlins <[email protected]>
Date:   Mon Feb 6 17:52:30 2023 -0800

    Remove unreachable_from_main linter rule (#120110)

    * Remove unreachable_from_main linter rule

    * Comment out

    * Update analysis_options.yaml

    ---------

    Co-authored-by: Michael Goderbauer <[email protected]>

commit e627e8d84147cbb58e2fad38415c805410917ce0
Author: Jenn Magder <[email protected]>
Date:   Mon Feb 6 15:52:52 2023 -0800

    Force web_tool_tests to run on x64 builders (#120128)

commit 575ced6c5a256403ea4f9a3c096df55e5be074d7
Author: Justin McCandless <[email protected]>
Date:   Mon Feb 6 15:51:11 2023 -0800

    Fix context menu web examples (#120104)

    The context menu examples on the docs site now work on the web.

commit ec524ed06871b5f594c1f786848b777a02c705a1
Author: 林洵锋 <[email protected]>
Date:   Tue Feb 7 06:50:07 2023 +0800

    Fix flutter_tools stuck when using custom LLDB prompt (#119443)

    * Fix flutter_tools stuck when using custom LLDB prompt

    * Remove trailing space character

    * Fix local variable name

    * Add comment

    * Remove trailing space character

    * Update packages/flutter_tools/lib/src/ios/ios_deploy.dart

    Co-authored-by: Jenn Magder <[email protected]>

    * Update packages/flutter_tools/lib/src/ios/ios_deploy.dart

    Co-authored-by: Jenn Magder <[email protected]>

    * Remove trailing space character

    ---------

    Co-authored-by: Jenn Magder <[email protected]>

commit 40b5e4cb5e7720cc5ab5edb59cb96eab5530d829
Author: Haroon Awan <[email protected]>
Date:   Mon Feb 6 21:45:39 2023 +0500

    Added "insertAll" and "removeAll" methods to AnimatedList (#115545)

    * Added "insertAll" and "removeAll" method to AnimatedList

    * Fixed doc

    * Changes in documentation asked by reviewwer

    * Removed unnecessary asserts.

    * Doc changes asked by reviewer.

    * Doc changes.

    ---------

    Co-authored-by: Rashid Khabeer <[email protected]>

commit 7bf1e99ea8076956d0b3733a88324e15948f93df
Author: engine-flutter-autoroll <[email protected]>
Date:   Mon Feb 6 10:51:51 2023 -0500

    Roll Plugins from 9302d87ee545 to d065e4e0a82a (6 revisions) (#120084)

    * 97a05241e [camera_android] Default to legacy recording profile when EncoderProfiles unavailable (flutter/plugins#7073)

    * a59517a03 Roll Flutter from d27880801435 to c5e8757fcb79 (54 revisions) (flutter/plugins#7092)

    * bde2ff0d7 Roll Flutter (stable) from b06b8b271095 to 7048ed95a5ad (5 revisions) (flutter/plugins#7091)

    * 1e58ab0f0 [in_app_pur]: Bump billing from 5.0.0 to 5.1.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/plugins#6701)

    * a5f40d751 Roll Flutter from c5e8757fcb79 to b8f5394a5ca6 (22 revisions) (flutter/plugins#7105)

    * d065e4e0a [gh_actions]: Bump actions/upload-artifact from 3.1.1 to 3.1.2 (flutter/plugins#6936)

commit 1bec87b4a13f943203c9dcea850a45e7ac145fa2
Author: stuartmorgan <[email protected]>
Date:   Mon Feb 6 07:51:47 2023 -0800

    Update Android TESTOWNERS (#119960)

    Updates the tests that were passed temporarily to me in #109717 to
    @reidbaker

commit 3c3c9a1bd98f464fc2c25751dac345dd61545ebd
Author: Eilidh Southren <[email protected]>
Date:   Mon Feb 6 14:39:14 2023 +0000

    [M3] Add ListTile's iconColor property support for icon buttons (#120075)

    * add icon button property override

    * list tile changes

    * add imports

    * add newlines

    * whitespace

commit 47a06746512f9a7196bf8c54bd3b904290249251
Author: Ben Konyi <[email protected]>
Date:   Mon Feb 6 09:23:35 2023 -0500

    Reland "Add --serve-observatory flag to run, attach, and test (#118402)"  (#119737)

    This reverts commit 254a796bc3f8a32d3e09c1416bce7b7b9f1ba33b.

commit bbca7ff693e27ac58119b8cc2a6d73099854b219
Author: Taha Tesser <[email protected]>
Date:   Mon Feb 6 11:02:37 2023 +0200

    Add Material 3 `SwitchListTile` example and update existing examples (#119714)

    * Add Material 3 `SwitchListTile` example and update existing examples

    * Update examples with `useMaterial3: true` and update example descriptions.

    * add a `ColorScheme` colour

commit b8f5394a5ca6d2bce062d9d0a20aaffb4289fb4c
Author: Christopher Fujino <[email protected]>
Date:   Sat Feb 4 23:06:19 2023 -0800

    [flutter_tools] Fix Future error handling ArgumentError in doctor --android-licenses (#119977)

    * wip

    * write test

    * make error handling printError

    * remove diff

commit 2e39badf989270d0509e39a69a956313f08599d8
Author: engine-flutter-autoroll <[email protected]>
Date:   Sun Feb 5 02:04:10 2023 -0500

    Roll Flutter Engine from 6bd500c38ea8 to 2a104cdfcdf8 (2 revisions) (#120022)

    * 65678e026 Roll Fuchsia Linux SDK from D0jJKibnSzSOs68QJ... to Z6Bdg2fbH4n5ptsKZ... (flutter/engine#39393)

    * 2a104cdfc Roll Skia from 8de8c6287254 to 45a4fdcc0cb0 (1 revision) (flutter/engine#39394)

commit 5187b45e4d1468c13ca9ab1795b300d876fd9453
Author: engine-flutter-autoroll <[email protected]>
Date:   Sat Feb 4 19:24:12 2023 -0500

    Roll Flutter Engine from c7a4bbab0e75 to 6bd500c38ea8 (2 revisions) (#120018)

    * f2d3dbda0 Roll Fuchsia Linux SDK from y0pMcSL4ejAh7JYTq... to D0jJKibnSzSOs68QJ... (flutter/engine#39386)

    * 6bd500c38 Roll Fuchsia Mac SDK from hcZFTTKMN0k4lXjfs... to j6dhXDhI_KUUyqTSF... (flutter/engine#39390)

commit f10e625eb276518a7373b1313008e987528509a1
Author: Brandon DeRosier <[email protected]>
Date:   Sat Feb 4 15:29:59 2023 -0800

    De-flake adapter integration test (#120016)

commit 61f6a0bcd4763c81b39fe24b7e98f37012211965
Author: engine-flutter-autoroll <[email protected]>
Date:   Sat Feb 4 03:08:35 2023 -0500

    Roll Flutter Engine from 1b132e44194d to c7a4bbab0e75 (6 revisions) (#119990)

    * 49f2d98d2 Roll Skia from f083b79aa388 to 5d8a7ed8acfe (3 revisions) (flutter/engine#39381)

    * 88fda68f4 Roll Skia from 5d8a7ed8acfe to 8de8c6287254 (1 revision) (flutter/engine#39382)

    * 23f53e5ef [fuchsia] Add output_path property to customize output path of .so files (flutter/engine#39007)

    * 87ed27470 Roll Fuchsia Mac SDK from _6bmpi47oMZC-msOI... to hcZFTTKMN0k4lXjfs... (flutter/engine#39384)

    * d3edcc985 Roll Dart SDK from de912d108ebb to a507a9057730 (2 revisions) (flutter/engine#39385)

    * c7a4bbab0 [Impeller] Make text appear less emboldened (flutter/engine#39383)

commit 5241d38fae782260100f9bdc96de7fcfdbd1a871
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Feb 3 22:32:28 2023 -0500

    Roll Flutter Engine from e1b265bb52aa to 1b132e44194d (8 revisions) (#119980)

    * 2ddbff9b6 [Impeller] Append to existing atlas if room exists, reuse texture (flutter/engine#38253)

    * 9dd2e9c98 [fuchsia] fdio_service_connect no longer provides rights which we need (flutter/engine#39374)

    * 9dde1563c [impeller] drawVertices blend mode (flutter/engine#38985)

    * 18750d245 [ios] Lock refresh rate to 80fps when threads are merged (flutter/engine#39172)

    * fe259c2ba Roll Skia from 83a3d8b16c94 to f083b79aa388 (5 revisions) (flutter/engine#39376)

    * 4fdbb0a36 [Impeller] Retain embolden/skew font properties when rendering text glyphs (flutter/engine#39378)

    * 868234df1 Roll Dart SDK from b7a0c75d4470 to de912d108ebb (1 revision) (flutter/engine#39379)

    * 1b132e441 [iOS] Ensure FlutterView's background color is not nil to avoid CAMetalLayer nextDrawable being time-consuming (flutter/engine#39359)

commit c8e75a8dff2fd753cac42d6736569dca7b7d5a44
Author: godofredoc <[email protected]>
Date:   Fri Feb 3 19:32:26 2023 -0800

    Do not run customer testing on release candidate branches. (#119979)

    These tests try to use a commit contemporary to the framework commit in
    customer repositories. This won't work because a CP to the framework
    release candidate branch may be recent even though the release candidate
    branch can be months old.

commit f7c2bd05f0167f9d9c8cc4e96f10dfc7a6a7c848
Author: godofredoc <[email protected]>
Date:   Fri Feb 3 18:57:53 2023 -0800

    Revert "Fix unable to find bundled Java version (#119244)" (#119981)

    This reverts commit 57fd50f84e013146ecfe40a3c77f8b0499bf59da.

commit 57fd50f84e013146ecfe40a3c77f8b0499bf59da
Author: crasowas <[email protected]>
Date:   Sat Feb 4 10:04:04 2023 +0800

    Fix unable to find bundled Java version (#119244)

commit 909dc30090af2b1e0914e273d2bc047f5a4bb925
Author: Jenn Magder <[email protected]>
Date:   Fri Feb 3 17:52:05 2023 -0800

    Verify Mac artifact codesigning on x64 and arm64 (#119971)

    * Verify Mac artifact codesigning on x64 and arm64

    * mac_arm64

commit 0fbef4693233537b8ae1d23932f708a06c794db7
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Feb 3 18:31:03 2023 -0500

    e1b265bb5 Roll Skia from 07a95bb37760 to 83a3d8b16c94 (5 revisions) (flutter/engine#39373) (#119967)

commit c24904ddee0dd880585644afa9c6379e1cb7c929
Author: Jenn Magder <[email protected]>
Date:   Fri Feb 3 14:38:53 2023 -0800

    Run macOS benchmarks in prod pool to upload metrics (#119963)

commit c52215e9356e26cd18e2f65c0d36de6f144fda74
Author: Jenn Magder <[email protected]>
Date:   Fri Feb 3 14:37:48 2023 -0800

    Run Mac hostonly tests on any available arch (#119884)

    * Run Mac hostonly tests on any available arch

    * Exception for framework tests

commit 3f02d4b4c35965a4aaa60bb1cbab7c9cba9e205a
Author: Callum Moffat <[email protected]>
Date:   Fri Feb 3 17:29:00 2023 -0500

    Tweak to floating-cursor-end behaviour (#119893)

    * Tweak to floating-cursor-end behaviour

    * Simplify

commit 51b05ac7e11e1966996efa61c4d92ec904d310ab
Author: Jenn Magder <[email protected]>
Date:   Fri Feb 3 13:36:48 2023 -0800

    Add mac_benchmark ci.yaml property (#119871)

    * Add mac_benchmark ci.yaml property

    * Remove presubmit

    * Bringup

    * Comma

    * gems

    * Test animated_complex_opacity_perf_macos__e2e_summary in presubmit

    * Try top-level mac_model

    * Move dependencies back into tasks

    * Add signing dependency

    * Revert animated_complex_opacity_perf_macos__e2e_summary test

commit 16f81e6561fdc3e925f215fc7a0801479425c8cf
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Feb 3 16:27:10 2023 -0500

    Roll Flutter Engine from 33d932efc68e to 110c643d6ac2 (3 revisions) (#119957)

    * 7e7a8a8b0 [impellerc] sort uniforms on metal backend  (flutter/engine#39366)

    * 16617b0a9 Roll Fuchsia Linux SDK from CAyoT0SrHHyXCMF31... to y0pMcSL4ejAh7JYTq... (flutter/engine#39371)

    * 110c643d6 Roll Skia from 62dcca5b175a to 07a95bb37760 (10 revisions) (flutter/engine#39369)

commit 9a7e18701ec8e09f77b2216650f23f240a70dbd7
Author: Christopher Fujino <[email protected]>
Date:   Fri Feb 3 11:24:41 2023 -0800

    [flutter_tools] fix Cannot delete file ENOENT from fuchsia_asset_builder (#119867)

    * fix

    * add test

commit be4c8c0eb13a30c8ad1e44f278b47af4adbc6396
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Feb 3 14:12:54 2023 -0500

    33d932efc Add gen_snapshot to windows flutter artifact. (flutter/engine#39353) (#119951)

commit b65ae62cf484351317eccaafe5f1056764e6861f
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Feb 3 13:26:08 2023 -0500

    Roll Flutter Engine from c39047ffb2a6 to 745d7efb5736 (3 revisions) (#119943)

    * 90427769f Fire UIA event on Checkbox state change (flutter/engine#39346)

    * dae0ebd00 Roll Dart SDK from be795cc64bd7 to b7a0c75d4470 (1 revision) (flutter/engine#39363)

    * 745d7efb5 Roll Fuchsia Mac SDK from 2xyEsodtHgcamPwX4... to _6bmpi47oMZC-msOI... (flutter/engine#39364)

commit 00b0d550c6847afe335825560efbd7ac119c25a7
Author: Justin McCandless <[email protected]>
Date:   Fri Feb 3 10:14:59 2023 -0800

    Fix iOS context menu position when flipped below (#119565)

    * Fix anchorBelow calculation, and share toolbar padding constant

    * Fix constant references in test

    * Test below position when padding is not offset by content distance

commit 96c8c6974186d6588efb6f082899dc198c1749bf
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Feb 3 12:37:02 2023 -0500

    Roll Flutter Engine from 0fb48ce5b118 to c39047ffb2a6 (2 revisions) (#119939)

    * 2e1c10382 Roll Skia from ee68f3edfa96 to 62dcca5b175a (1 revision) (flutter/engine#39362)

    * c39047ffb Roll buildroot to 39b486f7 (flutter/engine#39361)

commit 7177c413a9e5df2b6cd1bcdcca91f2227a58e80d
Author: Taha Tesser <[email protected]>
Date:   Fri Feb 3 18:27:43 2023 +0200

    Add Material 3 `RadioListTile` example and update existing examples (#119716)

    * Add Material 3 `RadioListTile` example and update existing examples

    * Update examples with `useMaterial3: true` and update example descriptions.

    * add a `ColorScheme` colour

commit c5e8757fcb795867f9f1ef42d7c2e98a74d6a231
Author: Eilidh Southren <[email protected]>
Date:   Fri Feb 3 14:35:12 2023 +0000

    Add M3 support for iconbuttons in error state in TextFields (#119925)

    * add m3 iconbutton override

    * changes

    * spring cleaning

    * whitespace fix

    * sneaky whitespaces

commit e0b2138ba764ae500b6d93443d9a87c805c7dc67
Author: Polina Cherkasova <[email protected]>
Date:   Fri Feb 3 06:31:47 2023 -0800

    Dispose OverlayEntry in TooltipState. (#117291)

commit fc8ea5620cc4407ce09c7a088109dceb7ae040a5
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Feb 3 08:54:27 2023 -0500

    0fb48ce5b Roll Dart SDK from 69452c5012d9 to be795cc64bd7 (1 revision) (flutter/engine#39360) (#119926)

commit a5d8a4a7272ed86ed17cee443d40afde022e415f
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Feb 3 05:07:21 2023 -0500

    67d35267c [Impeller] Use minimal coverage for stencil restores after overdraw prevention (flutter/engine#39358) (#119910)

commit 6b83eff56f385fa305664b08beb780e78fec84f7
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Feb 3 03:15:16 2023 -0500

    Roll Flutter Engine from e3fe6dade964 to 655530e3fd15 (5 revisions) (#119905)

    * 7422df491 [impellerc] sort uniforms on metal backend (flutter/engine#39345)

    * d94924742 Roll Fuchsia Linux SDK from pWloCaRzjLEAUvQEz... to CAyoT0SrHHyXCMF31... (flutter/engine#39354)

    * f4fbbe38c Roll Skia from a4079ec4c399 to ee68f3edfa96 (1 revision) (flutter/engine#39355)

    * 6425ae2b5 Revert "[impellerc] sort uniforms on metal backend (#39345)" (flutter/engine#39356)

    * 655530e3f Roll Dart SDK from 283b05994d68 to 69452c5012d9 (1 revision) (flutter/engine#39357)

commit 69421c1682e641970f25dd7a18f0123b9f67fb3f
Author: Jonah Williams <[email protected]>
Date:   Thu Feb 2 23:28:57 2023 -0800

    [framework] use shader tiling instead of repeated calls to drawImage (#119495)

    * [framework] use shader tiling instead of repeated calls to drawImage

    * ++

    * ++

    * review and test updates

    * ++

    * Update decoration_image.dart

    * Update decoration_image.dart

    * ++

    * ++

    * ++

    * ++

    * ++

    * Update painting.dart

    * Update decoration_test.dart

commit f3effce63037728b344a69eb5ed62452e8e94510
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Feb 3 00:07:10 2023 -0500

    Roll Flutter Engine from 2696fff8716d to e3fe6dade964 (3 revisions) (#119892)

    * a2f53699c Roll Dart SDK from 73b03bb636d3 to 283b05994d68 (2 revisions) (flutter/engine#39349)

    * 0e38e5304 Roll Skia from 4f0166baf5a4 to a4079ec4c399 (1 revision) (flutter/engine#39351)

    * e3fe6dade Roll Fuchsia Mac SDK from rqjJA8z_K0gdGcsvA... to 2xyEsodtHgcamPwX4... (flutter/engine#39352)

commit bc45b18589a04ee27852d20ca2d00b01638db088
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Feb 2 21:37:03 2023 -0500

    2696fff87 Roll Skia from c2d81db3ef41 to 4f0166baf5a4 (13 revisions) (flutter/engine#39348) (#119879)

commit 3570cce58ef938604ba4996c626cae021c5412f2
Author: Kate Lovett <[email protected]>
Date:   Fri Feb 3 04:34:17 2023 +0300

    Remove deprecated kind in GestureRecognizer et al (#119572)

    * Remove deprecated kind in GestureRecognizer et al

    * Fix null case

commit a27802e2dbc85b5f8a785653c4ad2587e7c2b0b7
Author: Kevin Moore <[email protected]>
Date:   Thu Feb 2 17:27:23 2023 -0800

    flutter_tool: remove explicit length header in HTTP response (#119869)

    This is already handled by pkg:shelf
    There is some subtlety with String here, since String.length might not
    align with the size in bytes over the wire, depending on the contents
    and the encoding

    Best to just let pkg:shelf handle it

commit c6264605d9f67dfd67f42811189ea80b98390842
Author: Greg Spencer <[email protected]>
Date:   Thu Feb 2 17:27:20 2023 -0800

    Make `_focusDebug` not interpolate in debug mode (#119680)

    * Make _focusDebug not interpolate in debug mode

    * Add test

    * Revert undesired change

    * Fix test to fail before too

    * Remove accidental skips

    * Switch to using a generating closure for arguments.

    * Remove a word

commit 66b2ca6383f61e3b2a6df0c0063d986ca82934b8
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Feb 2 19:55:07 2023 -0500

    Roll Flutter Engine from 616ecd8be3de to 2871970337df (3 revisions) (#119870)

    * a77e7bcb9 [web] Update the within() matcher to be more useful (flutter/engine#39288)

    * dbf401f97 [Impeller] Don't ceil subpass texture sizes (flutter/engine#39336)

    * 287197033 Bump ninja version to 1.11.1 (flutter/engine#39347)

commit 9b86a4853e73189379820271952766c26b84aef0
Author: Jessica Pereira <[email protected]>
Date:   Thu Feb 2 21:15:58 2023 -0300

    Fix gets removedItem instead of its index (#119638)

    * fix: gets removedItem instead of its index
    add: sliver_animated_list.0_test.dart

    * fix: sliver_animated_list.0_test.dart

    * fix: pr comments

    * fix test import

    Co-authored-by: Taha Tesser <[email protected]>

    ---------

    Co-authored-by: Taha Tesser <[email protected]>

commit d875899a65dc89d23103783e594bed410328109a
Author: Jenn Magder <[email protected]>
Date:   Thu Feb 2 16:14:42 2023 -0800

    Bump test Chrome version for Mac arm support (#119773)

commit cfdc35859eacad57d91010878dd5992b215764ad
Author: Flutter GitHub Bot <[email protected]>
Date:   Thu Feb 2 18:59:49 2023 -0500

    roll packages (#119865)

commit 72f9cf54871a97a857d69873ffe6da0a884dd4b5
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Feb 2 18:08:27 2023 -0500

    Roll Flutter Engine from ae38c9585a61 to 616ecd8be3de (3 revisions) (#119859)

    * 510ecfa93 Don't rely on timings for dimension_prov…
@CaseyHillers CaseyHillers mentioned this pull request Feb 17, 2023
Merged
8 tasks
0xZOne pushed a commit to 0xZOne/engine that referenced this pull request Feb 20, 2023
@bdero @0xZOne
Add Animated PNG demuxer (flutter#31098)
35da7ce
dnfield
dnfield reviewed Mar 7, 2023
View reviewed changes
lib/ui/painting/multi_frame_codec.cc
*lastRequiredFrame_)) {
prior_frame_index = requiredFrameIndex;
<< " is not cached. Using blank slate instead.";
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a bug. Will follow up with some more details shortly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For GIFs at least, this isn't safe. I vaguely remember discussing this before a while back. Something like the current frame can end up depending on the last frame and the framework doesn't draw both the last and current frame so it needs a complete frame.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(IOW, the GIF can require a last frame that was several frames ago but still needs to be painted)

Copy link
Member Author

@bdero bdero Mar 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the SkBitmap allocation not getting initialized with zeroes? This logic change should make the action of copying the last frame more restrictive, not less. We were copying the previous frame's contents in cases where we're supposed to composite atop a blank frame, which was visible in this webp as well: flutter/flutter#61150 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that it needs to be less restrictive, in the example GIF I have

@dnfield dnfield mentioned this pull request Mar 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnfield dnfield dnfield left review comments

@toneyzeng toneyzeng toneyzeng left review comments

@jason-simmons jason-simmons jason-simmons approved these changes

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

@zanderso zanderso Awaiting requested review from zanderso

Assignees
No one assigned
Labels
affects: engine platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for APNG (Animated PNG)
9 participants
@bdero @toneyzeng @sveinbjornt @chinmaygarde @everskies @skia-gold @eximius313 @dnfield @jason-simmons