[macos] Enable macOS platform views only for Metal #30853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
commented
Jan 13, 2022
shell/platform/darwin/macos/framework/Source/FlutterViewController_Internal.h
Outdated
Show resolved
Hide resolved
iskakaushik
force-pushed
the
macos-pv
branch
3 times, most recently
from
74338e9 to
00422f0
Compare
iskakaushik
changed the title
Can we do static thread merging (with a info.plist key) for this as a beta version? |
cyanglaz
reviewed
Jan 15, 2022
shell/platform/darwin/macos/framework/Headers/FlutterPlatformViews.h
Outdated
Show resolved
Hide resolved
shell/platform/darwin/macos/framework/Headers/FlutterPlatformViews.h
Outdated
Show resolved
Hide resolved
shell/platform/darwin/macos/framework/Headers/FlutterPlatformViews.h
Outdated
Show resolved
Hide resolved
shell/platform/darwin/macos/framework/Source/FlutterMetalCompositor.mm
Outdated
Show resolved
Hide resolved
shell/platform/darwin/macos/framework/Source/FlutterMetalCompositor.mm
Outdated
Show resolved
Hide resolved
shell/platform/darwin/macos/framework/Source/FlutterPlatformViewController.mm
Show resolved
Hide resolved
shell/platform/darwin/macos/framework/Source/FlutterPlatformViewController.mm
Outdated
Show resolved
Hide resolved
shell/platform/darwin/macos/framework/Source/FlutterPlatformViewController.h
Outdated
Show resolved
Hide resolved
shell/platform/darwin/macos/framework/Source/FlutterPlatformViewController.mm
Outdated
Show resolved
Hide resolved
shell/platform/darwin/macos/framework/Source/FlutterPlatformViewController.mm
Outdated
Show resolved
Hide resolved
cyanglaz
approved these changes
Jan 20, 2022
shell/platform/darwin/macos/framework/Source/FlutterPlatformViewController.mm
Outdated
Show resolved
Hide resolved
* The plan is to only support platform views when using Metal rendering backend. * This PR is based on the work done in: flutter#22905 * There are some threading issues to be addressed still to make this feature usable: flutter/flutter#96668 * Example is at: https://github.com/iskakaushik/flutter_macos_platform_view_example
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 21, 2022
| * the Dart code, this will be null. Otherwise this will be the value sent from the Dart code as | ||
| * decoded by `createArgsCodec`. | ||
| */ | ||
| - (nonnull NSView*)createWithviewIdentifier:(int64_t)viewId arguments:(nullable id)args; |
There was a problem hiding this comment.
view is incorrectly capitalized. This should be fixed ASAP as it is a breaking change.
There was a problem hiding this comment.
Fixing this at: #30996, I will make a follow up PR for the other issues raised.
| * Only implement this if `createWithFrame` needs an arguments parameter. | ||
| */ | ||
| @optional | ||
| - (nullable NSObject<FlutterMessageCodec>*)createArgsCodec; |
There was a problem hiding this comment.
This ideally shouldn't have "create" in the name; that's not standard naming for a getter. There's no reason this needs to create something every time.
| #import "flutter/shell/platform/darwin/macos/framework/Source/FlutterRenderingBackend.h" | ||
| #import "flutter/shell/platform/darwin/macos/framework/Source/FlutterViewController_Internal.h" | ||
| #include "flutter/shell/platform/embedder/embedder.h" | ||
| #import "flutter/shell/platform/embedder/embedder.h" |
There was a problem hiding this comment.
This change violates the style guide
| /** | ||
| * Creates a platform view channel and sets up the method handler. | ||
| */ | ||
| - (void)setupPlatformViewChannel; |
There was a problem hiding this comment.
The verb is "set up", so this should be setUpPlatformViewChannel
| @@ -219,6 +238,9 @@ - (instancetype)initWithName:(NSString*)labelPrefix | |||
| name:NSCurrentLocaleDidChangeNotification | |||
| object:nil]; | |||
|
|
|||
| _platformViewController = [[FlutterPlatformViewController alloc] init]; | |||
| [self setupPlatformViewChannel]; | |||
There was a problem hiding this comment.
You should never call methods on self in init.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses: flutter/flutter#41722