Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fixes the accessibilityContainer of FlutterScrollableSemanticsObject #29771

Merged
fluttergithubbot merged 1 commit into from
Nov 18, 2021
Merged

Fixes the accessibilityContainer of FlutterScrollableSemanticsObject #29771

fluttergithubbot merged 1 commit into from
Nov 18, 2021
+63 −4

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Nov 16, 2021

fixes flutter/flutter#92853

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Nov 16, 2021
@chunhtai chunhtai requested a review from gaaclarke November 16, 2021 22:58
@chunhtai
Copy link
Contributor Author

chunhtai commented Nov 16, 2021

cc @dnfield

@chunhtai chunhtai force-pushed the issues/92853 branch 2 times, most recently from c57aeac to d3e3a48 Compare November 17, 2021 00:43
@chunhtai chunhtai added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 17, 2021
@fluttergithubbot fluttergithubbot merged commit 5a26133 into flutter:main Nov 18, 2021
@jmagman
Copy link
Member

jmagman commented Nov 18, 2021

fyi @cyanglaz since you worked on #29531

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 18, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 18, 2021
@engine-flutter-autoroll
5a26133 Fixes the accessibilityContainer of FlutterScrollableSemantic…
97aee72 
…sObject (flutter/engine#29771)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-ios waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

iOS a11y gets stuck in nested scrollables

4 participants

@chunhtai @jmagman @dnfield @fluttergithubbot