This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Discard the resubmitted layer tree of the wrong size instead of rendering it #28474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Sep 9, 2021
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Just a minor nit about the naming convention but otherwise LGTM.
shell/common/rasterizer.cc
Outdated
| [weak_this = weak_factory_.GetWeakPtr(), pipeline, | ||
| resubmit_recorder = std::move(resubmit_recorder)]() mutable { | ||
| resubmit_recorder = std::move(resubmit_recorder), | ||
| discardCallback = std::move(discardCallback)]() mutable { |
Member
There was a problem hiding this comment.
Nit: Here and elsewhere, can we underscore case this before landing?
shell/common/shell_unittests.cc
Outdated
| raster_thread_merger_ref = raster_thread_merger; | ||
| } | ||
| if (should_merge_thread) { | ||
| // TODO(cyanglaz): This test used external_view_embedder so we need to |
Member
There was a problem hiding this comment.
I don't think comment is related.
ColdPaleLight
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 10, 2021
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 10, 2021
* 1720dda Roll Fuchsia Mac SDK from 5hlfN-425... to crjfjPXZN... (flutter/engine#28540) * 7135100 Roll Dart SDK from c1f80cf5fde6 to 5171a2583ace (1 revision) (flutter/engine#28541) * 825c409 Discard the resubmitted layer tree of the wrong size instead of rendering it (flutter/engine#28474)
yx-mike
added a commit
to yx-mike/engine
that referenced
this pull request
Dec 31, 2021
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discard the resubmitted layer tree of the wrong size instead of rendering it.
This is a tiny patch for this PR: #21179
Pre-launch Checklist
writing and running engine tests.
///).