Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@swift-kim
Copy link
Contributor

@swift-kim swift-kim commented Jul 16, 2021

The code is dead because #17755 has been reverted by #19136,
although #18519 has not been properly reverted.

cc @GaryQian

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

The code is dead because flutter#17755 has been reverted by flutter#19136,
although flutter#18519 has not been properly reverted.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@chinmaygarde
Copy link
Member

@GaryQian Since you were the author of the reverted PR, can you please take a look and sign off on this?

@chinmaygarde
Copy link
Member

Is this still on your radar Gary?

Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the catch!

@GaryQian GaryQian added waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. tech-debt Technical debt, code quality, testing, etc. and removed needs tests labels Aug 30, 2021
@GaryQian GaryQian changed the title Remove unnecessary code from the iOS embedder Remove dead localization code from the iOS embedder Aug 30, 2021
@fluttergithubbot fluttergithubbot merged commit efbf7dc into flutter:master Aug 30, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes platform-ios tech-debt Technical debt, code quality, testing, etc. waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants