Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Move path part files to libraries #25842

Merged
ferhatb merged 3 commits into from
Apr 30, 2021
Merged

Move path part files to libraries #25842

ferhatb merged 3 commits into from
Apr 30, 2021

Conversation

@ferhatb
Copy link
Contributor

@ferhatb ferhatb commented Apr 29, 2021

Refactor part of migrating from part files to libraries.

  • Moved some private helper functions for conics and cubics into respective classes and made public.
  • Removed duplicate validators, switched code to use validators.dart.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the [engine presubmit flakes form] before re-triggering the failure.

@ferhatb ferhatb added the platform-web Code specifically for the web engine label Apr 29, 2021
@ferhatb ferhatb requested a review from mdebbar April 29, 2021 19:42
@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 29, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Apr 29, 2021
mdebbar
mdebbar approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Especially util.dart since it's used everywhere.

@ferhatb ferhatb merged commit f45f52f into flutter:master Apr 30, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2021
@engine-flutter-autoroll
f45f52f Move path part files to libraries (flutter/engine#25842)
f10bf4b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2021
@engine-flutter-autoroll
f45f52f Move path part files to libraries (flutter/engine#25842)
9afb9c7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2021
@engine-flutter-autoroll
f45f52f Move path part files to libraries (flutter/engine#25842)
436a354
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2021
@engine-flutter-autoroll
f45f52f Move path part files to libraries (flutter/engine#25842)
1341c72
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2021
@engine-flutter-autoroll
f45f52f Move path part files to libraries (flutter/engine#25842)
38d2727
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2021
@engine-flutter-autoroll
f45f52f Move path part files to libraries (flutter/engine#25842)
7caf203
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2021
@engine-flutter-autoroll
f45f52f Move path part files to libraries (flutter/engine#25842)
9a1bffc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2021
@engine-flutter-autoroll
f45f52f Move path part files to libraries (flutter/engine#25842)
ca91b75
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 2, 2021
@engine-flutter-autoroll
f45f52f Move path part files to libraries (flutter/engine#25842)
c60208a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 2, 2021
@engine-flutter-autoroll
f45f52f Move path part files to libraries (flutter/engine#25842)
88017bf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 3, 2021
@engine-flutter-autoroll
f45f52f Move path part files to libraries (flutter/engine#25842)
1d40a2e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 3, 2021
@engine-flutter-autoroll
f45f52f Move path part files to libraries (flutter/engine#25842)
5a5808a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 3, 2021
@engine-flutter-autoroll
f45f52f Move path part files to libraries (flutter/engine#25842)
9467a0a
zanderso pushed a commit to flutter/flutter that referenced this pull request May 3, 2021
@engine-flutter-autoroll
Roll Engine from 3e578c6 to 578449f (23 revisions) (#81700)
d4d2855 
* aac3658 Roll Skia from 14efdd3d50db to 3010f3d79193 (4 revisions) (flutter/engine#25857)

* f45f52f Move path part files to libraries (flutter/engine#25842)

* d96669f Roll Skia from 3010f3d79193 to 5276ba274b38 (1 revision) (flutter/engine#25859)

* 43994ab Use "blur_sigma" instead of "blur_radius" in Shadow. (flutter/engine#25760)

* 74ac010 Roll Dart SDK from 1e3e5efcd47e to 6397e8b91103 (18 revisions) (flutter/engine#25861)

* d462cfd Remove flake inducing timeouts (flutter/engine#25847)

* 258f63a Roll Skia from 5276ba274b38 to 31fddc376993 (14 revisions) (flutter/engine#25862)

* 1bf01a1 fuchsia: Reliably forward View insets (flutter/engine#25381)

* 2740062 Roll Skia from 31fddc376993 to 097263bb5089 (1 revision) (flutter/engine#25865)

* 4aae6b3 Roll Dart SDK from 6397e8b91103 to ee8eb0a65efa (1 revision) (flutter/engine#25869)

* d1f31c7 Roll Skia from 097263bb5089 to 5dfb3f40684b (1 revision) (flutter/engine#25870)

* 428ef10 deflake (flutter/engine#25864)

* 01b9db8 Roll Dart SDK from ee8eb0a65efa to 8c109a734bdc (1 revision) (flutter/engine#25872)

* e623c09 Roll Dart SDK from 8c109a734bdc to b98a1eec5eb5 (1 revision) (flutter/engine#25873)

* 7ce6226 Roll Dart SDK from b98a1eec5eb5 to 6ecae204598d (1 revision) (flutter/engine#25874)

* 554c24c Roll Skia from 5dfb3f40684b to 5c95bcb48b9b (1 revision) (flutter/engine#25876)

* 03bd2e3 Roll Dart SDK from 6ecae204598d to 3cc6cdab8eaf (2 revisions) (flutter/engine#25877)

* 53fdd89 Roll Skia from 5c95bcb48b9b to c779d432f336 (1 revision) (flutter/engine#25880)

* 98ee65b Roll Skia from c779d432f336 to ff8b52df55ff (2 revisions) (flutter/engine#25881)

* d84caa7 Roll Dart SDK from 3cc6cdab8eaf to b8f4018535fa (2 revisions) (flutter/engine#25885)

* 156760e Roll Skia from ff8b52df55ff to ec79349bad50 (1 revision) (flutter/engine#25886)

* 23cd8e5 Revert the Dart SDK to 1e3e5efcd47edeb7ae5a69e146c8ea0559305a98 (flutter/engine#25887)

* 578449f Fix crash when both FlutterFragmentActivity and FlutterFragment are destroyed and recreated (flutter/engine#25851)
gspencergoog pushed a commit to gspencergoog/engine that referenced this pull request May 5, 2021
@ferhatb @gspencergoog
Move path part files to libraries (flutter#25842)
f0c5e1f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mdebbar mdebbar mdebbar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ferhatb @mdebbar