-
Notifications
You must be signed in to change notification settings - Fork 6k
Enable JIT memory protection on macOS #25819
Enable JIT memory protection on macOS #25819
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, this is for a native Apple Silicon build. Makes sense.
cbracken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Belated lgtm -- thank you!
flutter/flutter#81208
This ensures that memory protection is enabled on both macOS and iOS.
Alternatively we might be able to just keep it enabled on ARM64 target, but i'm not sure it's worth the hassle.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.