This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Deduplicate plugin registration logic and make error logs visible" #25390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
previously approved these changes
Apr 2, 2021
Member
|
This produces more error logcat outputs which is the intent. The internal tests need to expect them explicitly which is also intended. |
Contributor
Author
|
Feel free to close if you have a plan for moving forward then. This PR isn't set to auto-merge so it won't merge unless we decide to. |
Contributor
Author
|
Closing per @angjieli |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #25297
This fix is causing internal testing errors downstream.