This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Fix layout exception when text is null #23653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatb
approved these changes
Jan 13, 2021
mdebbar
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 13, 2021
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Jan 20, 2021
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabling the new rich paragraph implementation caused some framework tests to fail. These tests were creating paragraphs with no spans, which is an edge that wasn't being handled. This PR fixes it.
Engine auto-roll failure: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_tests/8457/overview
The framework tests that failed were in these files:
test/painting/text_painter_test.darttest/rendering/semantics_and_children_test.dart