Support Mice in iPadOS 13.4+ #23636
Support Mice in iPadOS 13.4+ #23636
Conversation
|
This adds the header guard in FlutterViewController.h |
| * Dart-related state and asynchronous tasks when navigating back and forth between a | ||
| * FlutterViewController and other `UIViewController`s. | ||
| */ | ||
| #ifdef __IPHONE_13_4 |
There was a problem hiding this comment.
This is conditionally removing the FLUTTER_EXPORT. If we want to go this route you should make the scope the the conditional compilation around the UIPointerInteractionDelegate.
There was a problem hiding this comment.
good catch, I'll fix that. We should be FLUTTER_EXPORTING in every case. My bad.
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
LGTM assuming you've tested it manually with the old SDK and you change the scope of the conditional compilation.
You might also get compilation errors about unrecognized selectors for the other mouse stuff too. That's why it would be nice to test this locally.
|
Quick update: @jmagman tested this locally with Xcode 11 and it worked for her, so I think we can go ahead and re-land this. I would have liked to have done a full CI dry-run on the Flutter side but apparently that's not doable yet - I've filed an issue to support that at flutter/flutter#73893. |
* d7b25f9 [web] Reland: Enable the new rich paragraph implementation (flutter/engine#23659) * 507a887 fix ax unique id flake (flutter/engine#23518) * e5a4c7c Roll Fuchsia Linux SDK from BUsKF6z4t... to a7ezEWPM5... (flutter/engine#23668) * 7d1e4e3 Roll Skia from 0e4a29af9db2 to af9b58e287b5 (10 revisions) (flutter/engine#23670) * 635f64a Roll Skia from af9b58e287b5 to f435ada424df (1 revision) (flutter/engine#23671) * 6957611 Roll Fuchsia Mac SDK from BsUY1yjWh... to BoBy7Eobf... (flutter/engine#23672) * 37131f1 Use non-deprecated SkImageFilter factory functions (flutter/engine#23649) * 38f08ff Roll Fuchsia Linux SDK from a7ezEWPM5... to erwxDS3kf... (flutter/engine#23676) * a56183c Roll Skia from f435ada424df to 8f78d5528438 (7 revisions) (flutter/engine#23680) * 9d75996 Revert "[web] Enable the new rich paragraph implementation (#23162)" (flutter/engine#23687) * b030bc8 Roll Dart SDK from 724d9e5e7d71 to 3629a798353d (1 revision) (flutter/engine#23681) * a8a7534 Support Mice in iPadOS 13.4+ (flutter/engine#23636) * 3f691f0 [web] Fix semantic node order for webkit (flutter/engine#23601) * 70d08c6 Roll Skia from 8f78d5528438 to 890b2b406a60 (9 revisions) (flutter/engine#23692) * 5459565 Roll Fuchsia Mac SDK from BoBy7Eobf... to DVYrV15dq... (flutter/engine#23693) * 3fd4c63 [web] Fix letter spacing for rich paragraphs (flutter/engine#23683) * effb529 Added missing export for the flutter engine group. (flutter/engine#23689)
2 participants
Description
Adds support for iOS 13.4 mouse support.
Redo of #23362
Related Issues
flutter/flutter#54663
flutter/flutter#55809
Tests
I added the following tests:
testPanGestureRecognizer
testMouseSupport
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Reviewer Checklist
Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.