Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Android deeplink sends "path + query" instead of just path #23561

Merged
chunhtai merged 8 commits into from
Jan 13, 2021
Merged

Android deeplink sends "path + query" instead of just path #23561

chunhtai merged 8 commits into from
Jan 13, 2021

Conversation

@sarbagyastha
Copy link
Contributor

@sarbagyastha sarbagyastha commented Jan 9, 2021 •
edited
Loading

Description

Currently, android platform only sends URL path obtained from deeplink . This PR sets route as path + query instead of just path.

The fix for iOS is in #23562

Related Issues

Fixes flutter/flutter#73637

Tests

I have updated the test files.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [contributor guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [C++, Objective-C, Java style guides] for the engine.
  • I read the [tree hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

  • I have submitted any presubmit flakes in this PR using the [engine presubmit flakes form] before re-triggering the failure.

Breaking Change

Did any tests fail when you ran them? Please read [handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change.

@sarbagyastha sarbagyastha mentioned this pull request Jan 9, 2021
Merged
10 tasks
@sarbagyastha sarbagyastha changed the title Send path+query from pushRoute in Android Android deeplink sends "path + query" instead of just path Jan 9, 2021
@sarbagyastha
Copy link
Contributor Author

sarbagyastha commented Jan 9, 2021

/cc @chunhtai

@chunhtai
Copy link
Contributor

chunhtai commented Jan 11, 2021

hi @sarbagyastha thanks for putting up the PR, cc @johnpryan This looks something we have missed, do we need to update the doc regarding this change?

chunhtai
chunhtai suggested changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the gitignore changes

@chunhtai chunhtai added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 12, 2021
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jan 12, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite build_and_test_linux_unopt_debug has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 12, 2021
@chunhtai chunhtai merged commit fb56b4b into flutter:master Jan 13, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 13, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 13, 2021
@engine-flutter-autoroll
fb56b4b Android deeplink sends "path + query" instead of just path (f…
4836973 
…lutter/engine#23561)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 13, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 13, 2021
@engine-flutter-autoroll
fb56b4b Android deeplink sends "path + query" instead of just path (f…
023a641 
…lutter/engine#23561)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 13, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 13, 2021
@engine-flutter-autoroll
fb56b4b Android deeplink sends "path + query" instead of just path (f…
077c5a7 
…lutter/engine#23561)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 13, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 13, 2021
@engine-flutter-autoroll
fb56b4b Android deeplink sends "path + query" instead of just path (f…
ade00ca 
…lutter/engine#23561)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 13, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 13, 2021
@engine-flutter-autoroll
fb56b4b Android deeplink sends "path + query" instead of just path (f…
04b237f 
…lutter/engine#23561)
zanderso pushed a commit to flutter/flutter that referenced this pull request Jan 13, 2021
@engine-flutter-autoroll
Roll Engine from 10cee6a to 648dae9 (25 revisions) (#73886)
c9b991d 
* 51dd6aa [web] Enable the new rich paragraph implementation (flutter/engine#23162)

* 0f9fc3d Roll Skia from 7cf3addb1bd8 to 93c2d81f199a (1 revision) (flutter/engine#23614)

* a1e7424 [dart-runner] Avoid calling Destroy on nullptr (flutter/engine#23608)

* 846d958 Windows textures: Add placeholder flutter_texture_registrar.h (flutter/engine#23623)

* 55afc18 Roll Dart SDK from 7fcbd388b620 to ef8bf7f0a667 (5 revisions) (flutter/engine#23628)

* d2b8154 [canvaskit] apply invser scale on the left (flutter/engine#23550)

* be1a3c0 Roll Fuchsia Linux SDK from UB6RsTbdU... to FfWbbB4r8... (flutter/engine#23633)

* f743c89 Roll Skia from 93c2d81f199a to 9fd75e96d712 (29 revisions) (flutter/engine#23635)

* cf42dbe Roll wuffs to google/wuffs@c86add2 (flutter/engine#23607)

* f1278d0 Link SkShaper/SkParagraph into the engine by default (flutter/engine#23626)

* fb56b4b Android deeplink sends "path + query" instead of just path (flutter/engine#23561)

* 22bb891 Plumbing refactor to allow the usage of Dart_CreateIsolateInGroup (flutter/engine#23549)

* 20991a5 Add accessibility suport to Linux shell. (flutter/engine#19634)

* 145922b Roll Dart SDK from ef8bf7f0a667 to 636ff0ec97e0 (1 revision) (flutter/engine#23639)

* 176ae6e Roll Fuchsia Mac SDK from oll0Dgp9o... to JSzm8D59u... (flutter/engine#23641)

* d2320a8 Roll Dart SDK from 636ff0ec97e0 to d3d7b77e8165 (1 revision) (flutter/engine#23642)

* 8bdd099 Roll Skia from 9fd75e96d712 to 38ca513408d1 (1 revision) (flutter/engine#23643)

* cc572e1 Roll Skia from 38ca513408d1 to be2a8614c5d6 (2 revisions) (flutter/engine#23644)

* e9383a0 Roll Dart SDK from d3d7b77e8165 to 010633edc631 (1 revision) (flutter/engine#23645)

* 9d6ed8b Roll Fuchsia Linux SDK from FfWbbB4r8... to BUsKF6z4t... (flutter/engine#23646)

* 6d55dd4 Roll Dart SDK from 010633edc631 to 724d9e5e7d71 (1 revision) (flutter/engine#23647)

* 299f081 Roll Skia from be2a8614c5d6 to 0d7de6bc9ac3 (1 revision) (flutter/engine#23648)

* 0ec99cf Roll Fuchsia Mac SDK from JSzm8D59u... to BsUY1yjWh... (flutter/engine#23650)

* 859494f Revert "[web] Enable the new rich paragraph implementation (#23162)" (flutter/engine#23651)

* 648dae9 Roll Skia from 0d7de6bc9ac3 to 92969f265686 (7 revisions) (flutter/engine#23652)
gspencergoog pushed a commit to gspencergoog/engine that referenced this pull request Jan 20, 2021
@sarbagyastha @gspencergoog
Android deeplink sends "path + query" instead of just path (flutter#2…
58bde11 
…3561)

* added .cpid & .gclient to gitignore

* updated tests

* minor change

* fixed formating

* compact concatenation

* minor change

* Revert "added .cpid & .gclient to gitignore"

* cleanup
This was referenced Feb 2, 2021
Closed
Merged
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@sarbagyastha @hjfreyer
Android deeplink sends "path + query" instead of just path (flutter#2…
bf92f9e 
…3561)

* added .cpid & .gclient to gitignore

* updated tests

* minor change

* fixed formating

* compact concatenation

* minor change

* Revert "added .cpid & .gclient to gitignore"

* cleanup
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@chunhtai chunhtai chunhtai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Platform deeplink doesn't respect query parameters

4 participants

@sarbagyastha @chunhtai @fluttergithubbot @googlebot