Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Implement tilemode for gradient shaders. #22597

Merged
ferhatb merged 10 commits into from
Nov 20, 2020
Merged

[web] Implement tilemode for gradient shaders. #22597

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1216d86
Add linear tile shader
ferhatb Nov 17, 2020
c681ca5
Merge remote-tracking branch 'upstream/master' into tilemode2
ferhatb Nov 17, 2020
ff2cefa
Add linear/radial gradient tilemode support
ferhatb Nov 18, 2020
0dcf254
update golden locks
ferhatb Nov 19, 2020
6c5aff6
Merge remote-tracking branch 'upstream/master' into tilemode2
ferhatb Nov 19, 2020
79bfe34
Address reviewer comments
ferhatb Nov 19, 2020
c809ab7
Fix gradient radial screenshot bounds
ferhatb Nov 19, 2020
4da8535
Update maxDiffRate for iOS
ferhatb Nov 20, 2020
e2a5b84
Remove write:true for screenshot test
ferhatb Nov 20, 2020
73147bf
Update diffrate for iOS
ferhatb Nov 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/web_ui/lib/src/engine/canvaskit/shader.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class CkGradientLinear extends CkShader implements ui.Gradient {
assert(_offsetIsValid(to)),
assert(colors != null), // ignore: unnecessary_null_comparison
assert(tileMode != null), // ignore: unnecessary_null_comparison
this.matrix4 = matrix == null ? null : _FastMatrix64(matrix) {
this.matrix4 = matrix {
if (assertionsEnabled) {
_validateColorStops(colors, colorStops);
}
Expand All @@ -77,7 +77,7 @@ class CkGradientLinear extends CkShader implements ui.Gradient {
final List<ui.Color> colors;
final List<double>? colorStops;
final ui.TileMode tileMode;
final _FastMatrix64? matrix4;
final Float64List? matrix4;

@override
SkShader createDefault() {
Expand Down
Loading