Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@aam
Copy link
Member

@aam aam commented Nov 7, 2020

Changes since last roll:

a188781c9fc (tag: 2.12.0-28.0.dev, origin/dev) Version 2.12.0-28.0.dev
9d132ebba9f Bump pub
391bc8d33d6 [vm/concurrency] Allow calling SafepointRwLock::IsCurrentThreadReader() inside safepoint operation scope
466f2fd8a79 Analyzer: prepare some generated/ tests for null safety
e90967f29de [SDK] Makes --lazy_async_stack default.
6101e4653b5 (origin/lkgr) [test/ffi] Add struct stack alignment test

Description

Replace this paragraph with a description of what this PR is doing. If you're
modifying existing behavior, describe the existing behavior, how this PR is
changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from our issue
database
. Indicate, which of these issues are resolved or fixed by this PR.
There should be at least one issue listed here.

Tests

I added the following tests:

Replace this with a list of the tests that you added as part of this PR. A
change in behaviour with no test covering it will likely get reverted
accidentally sooner or later. PRs must include tests for all
changed/updated/fixed behaviors. See testing the engine for instructions on
writing and running engine tests.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

Changes since last roll:
```
a188781 (tag: 2.12.0-28.0.dev, origin/dev) Version 2.12.0-28.0.dev
9d132eb Bump pub
391bc8d [vm/concurrency] Allow calling SafepointRwLock::IsCurrentThreadReader() inside safepoint operation scope
466f2fd Analyzer: prepare some generated/ tests for null safety
e90967f [SDK] Makes --lazy_async_stack default.
6101e46 (origin/lkgr) [test/ffi] Add struct stack alignment test
```
@google-cla google-cla bot added the cla: yes label Nov 7, 2020
@aam aam requested a review from a-siva November 7, 2020 03:48
@aam
Copy link
Member Author

aam commented Nov 7, 2020

Made obsolete by #22375 and subsequent automated roll.

@aam aam closed this Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant