Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] fix type error during hot restart in font manager #22248

Merged
jonahwilliams merged 1 commit into from
Nov 2, 2020
Merged

[web] fix type error during hot restart in font manager #22248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/web_ui/lib/src/engine/canvaskit/fonts.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const String _robotoUrl =
class SkiaFontCollection {
/// Fonts that have been registered but haven't been loaded yet.
final List<Future<_RegisteredFont?>> _unloadedFonts =
Copy link
Contributor Author

@jonahwilliams jonahwilliams Nov 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this was allowed by the type system

<Future<_RegisteredFont>>[];
<Future<_RegisteredFont?>>[];

/// Fonts which have been registered and loaded.
final List<_RegisteredFont> _registeredFonts = <_RegisteredFont>[];
Expand Down