This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Fix positioning of canvas elements due to svg filters #22070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
approved these changes
Oct 23, 2020
yjbanov
approved these changes
Oct 23, 2020
| } | ||
|
|
||
| bool _offsetIsValid(ui.Offset offset) { | ||
| assert(offset != null, 'Offset argument was null.'); // ignore: unnecessary_null_comparison |
Contributor
There was a problem hiding this comment.
Why are asserts removed? Do we check for null elsewhere?
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 26, 2020
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relanding #21939 reverted due to TP2.
Related Issues
flutter/flutter#59451
flutter/flutter#68213
flutter/flutter#65616
Tests
I added the following tests:
color_filter_blendMode_overlay.png golden test.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Reviewer Checklist
Breaking Change
Did any tests fail when you ran them? Please read [handling breaking changes].