Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@mpcomplete
Copy link
Contributor

This adds initial support for the Google Cloud Messaging API.

  • New gcm mojo service with partial android implementation.
  • Updated android build rules to Chromium's current copy; also removed unnecessary proguard support.

@abarth
Copy link
Contributor

abarth commented Dec 14, 2015

How does this change affect the final size of the APK?

@mpcomplete
Copy link
Contributor Author

Before:

-rw-r----- 1 mpcomplete eng 8952459 Dec 14 16:17 Fitness.apk
-rw-r----- 1 mpcomplete eng 8387175 Dec 14 16:02 SkyShell.apk

After:

-rw-r----- 1 mpcomplete eng 12020761 Dec 14 15:24 Fitness.apk
-rw-r----- 1 mpcomplete eng 11459987 Dec 14 15:18 SkyShell.apk

@abarth
Copy link
Contributor

abarth commented Dec 14, 2015

3MB is probably more than we want to pay in the default build. Can we make GCM an optional module that an app can add if it wants it? Rather than having a monolithic APK that grows as we add more services, I'd like to get to a model where a developer can pick the services they want from a gallery of services and they only pay the costs for the services they've picked.

@collinjackson and I have been talking about how to do this for Firebase. It sounds like we'll want that sort of thing for GCM as well.

@mpcomplete
Copy link
Contributor Author

Yeah, I definitely want to make it optional (and also in a separate repo). I haven't thought yet about how to do that, but I hope we can use the same mechanism for all the service types we want to add (location, camera, etc).

BUILD.gn Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example no longer exists in this repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I have it symlinked for easy building. Not for checkin.

New gcm mojo service with Android implementation.

Temporarily checking into flutter repo until it's easier to add third
party services.
@collinjackson
Copy link
Contributor

lgtm

mpcomplete added a commit that referenced this pull request Jan 7, 2016
First steps toward GCM support
@mpcomplete mpcomplete merged commit 93a9d52 into master Jan 7, 2016
@mpcomplete mpcomplete deleted the gcm branch January 7, 2016 20:41
rhencke pushed a commit to rhencke/engine that referenced this pull request Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants