Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Contributor

Description

The C API for the C++ shared embedding code used by Windows and GLFW
initiall just referred to the PluginRegistrar as "Registrar". Since
there will be at least one more registrar (the TextureRegistrar), this
renames them to avoid ambiguity.

This alligns the rest of the C API with changes already made for the
Windows-specific additions.

Related Issues

None

Tests

I added the following tests: Existing tests have been updated to the new names

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

The C API for the C++ shared embedding code used by Windows and GLFW
initiall just referred to the PluginRegistrar as "Registrar". Since
there will be at least one more registrar (the TextureRegistrar), this
renames them to avoid ambiguity.

This alligns the rest of the C API with changes already made for the
Windows-specific additions.
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants