This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fixed ios layout change to not refocus semantics object if the focus … #21029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is outside of flutter
gaaclarke
approved these changes
Sep 8, 2020
| } | ||
|
|
||
| void AccessibilityBridge::AccessibilityObjectDidLoseFocus(int32_t id) { | ||
| if (last_focused_semantics_object_id_ == id) |
Member
There was a problem hiding this comment.
Please add curly braces to make turning the linter on for mac easier.
|
|
||
| void AccessibilityBridge::AccessibilityObjectDidLoseFocus(int32_t id) { | ||
| if (last_focused_semantics_object_id_ == id) | ||
| last_focused_semantics_object_id_ = -1; |
Member
There was a problem hiding this comment.
Can you do a define for this magic value, something like kSemanticObjectIdInvalid?
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…is outside of flutter
Description
We try to refocus the last focused semantics object when layout changes, but that does not take into account when the focus went outside of the flutter application (for example soft keyboard). This will interrupt the user focus and make the focus jump back to flutter.
This PR fixes it by making the semantics objects to notify the bridge when it lose focus, so that the bridge can accurately keep track of whether the focus has gone to outside of the app.
Related Issues
Fixes flutter/flutter#65423
Tests
I added the following tests:
see files
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.