Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@blasten
Copy link

@blasten blasten commented Aug 24, 2020

Description

Enables hybrid composition on Android by default.
#20721 should be merged prior to this PR.

Related Issues

Fixes flutter/flutter#59930
Fixes flutter/flutter#63585

Tests

This is tested in e2e tests.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@auto-assign auto-assign bot requested a review from GaryQian August 24, 2020 05:14
@blasten blasten requested review from cyanglaz and removed request for GaryQian August 24, 2020 05:14
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Only have doubts about not utilizing GLContextSwitch.

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Offline discussion: we will re-work how rasterizer uses gl context switch, to make sure it works with unobstructed platform views.

@blasten blasten merged commit d16ba48 into flutter:master Aug 24, 2020
@blasten blasten deleted the enable_android_pv branch August 24, 2020 20:10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 24, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2020
blasten pushed a commit that referenced this pull request Aug 25, 2020
blasten pushed a commit that referenced this pull request Aug 25, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2020
blasten pushed a commit to blasten/engine that referenced this pull request Aug 28, 2020
blasten pushed a commit that referenced this pull request Aug 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support dynamic thread merging on Android EGL context cannot be shared between threads

3 participants